Skip to content

Use const in test-require-json.js #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarahmeyer wants to merge 2 commits into from
Closed

Use const in test-require-json.js #9904

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f369a
use const instead of var in test/parallel/test-require-json.js
sarahmeyer Dec 1, 2016
db1001e
Merge branch 'test-require-json-use-const' of github.com:sarahmeyer/n…
sarahmeyer Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use const instead of var in test/parallel/test-require-json.js
  • Loading branch information
@sarahmeyer
sarahmeyer committed Dec 1, 2016
commit a8f369a7a3c73c0153f385dd885fdbf5db1c59ad
10 changes: 5 additions & 5 deletions test/parallel/test-require-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
'use strict';
var common = require('../common');
var path = require('path');
var assert = require('assert');
const common = require('../common');
const path = require('path');
const assert = require('assert');

try {
require(path.join(common.fixturesDir, 'invalid.json'));
} catch (err) {
var re = /test[/\\]fixtures[/\\]invalid.json: Unexpected string/;
var i = err.message.match(re);
const re = /test[/\\]fixtures[/\\]invalid.json: Unexpected string/;
const i = err.message.match(re);
assert.notStrictEqual(null, i, 'require() json error should include path');
}