Skip to content

events: remove unneeded safety check code #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
captainsafia wants to merge 1 commit into from
Closed

events: remove unneeded safety check code #9866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
events: remove unneeded safety check code 
In the process of creating #9865, it was discovered that the code
checking whether or not events was defined was unnecessary because
the only situation in which events would be undefined is if it is
monkeypatched by an external entity. This should be removed in order
to discourage this. If the test added in #9865 is merged, it will
need to removed on merge of this commit.
  • Loading branch information
@captainsafia
captainsafia committed Dec 1, 2016
commit 46ea5b68a99bd8bfde6cb6e19624290b2d634dd4
16 changes: 6 additions & 10 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,17 +423,13 @@ EventEmitter.prototype.listeners = function listeners(type) {
var ret;
var events = this._events;

if (!events)
evlistener = events[type];
if (!evlistener)
ret = [];
else {
evlistener = events[type];
if (!evlistener)
ret = [];
else if (typeof evlistener === 'function')
ret = [evlistener.listener || evlistener];
else
ret = unwrapListeners(evlistener);
}
else if (typeof evlistener === 'function')
ret = [evlistener.listener || evlistener];
else
ret = unwrapListeners(evlistener);

return ret;
};
Expand Down