-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Improvements to tls API documentation, batch 1 #9800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8ea758c
tls: fix/annotate connect arg comments
sam-github 516a9d9
tls: document and test option-less createServer
sam-github cd1fdfb
test: tls key/cert ordering not necessary
sam-github 28a3045
tls: do not refer to secureOptions as flags
sam-github 53cfdb0
doc: document all TLSSocket options
sam-github 43b8c9e
doc: describe all tls.connect() variants
sam-github c94b954
doc: socket passed to tls.connect is user managed
sam-github b9a6642
doc: describe tls passphrase use with pfx and key
sam-github 8c25224
doc: describe tls cert and ca options
sam-github 90e01ff
doc: describe buffer forms of tls crl option
sam-github 706efcd
doc: describe tls cipher option and defaults
sam-github be11388
doc: fix link to Crypto Constants
sam-github 17405b6
doc: honorCipherOrder sets CIPHER_SERVER_PREFERENCE
sam-github 5c078e5
doc: describe tls ecdhCurve/dhparam options
sam-github e8e59e4
doc: describe tls secureProtocol option
sam-github 797b334
doc: describe tls secureOptions
sam-github 5a85e08
doc: describe tls sessionIdContext
sam-github bb89227
doc: de-deduplicate secure context docs
sam-github a52555e
test: var to const in tls-no-cert-required
sam-github File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: de-deduplicate secure context docs
The secure context options were documented 4 times, making it difficult to understand where the options come from, where they are supported, and under what conditions they are used. The multiple copies were inconsistent and contradictory in their descriptions of the options, and also inconsistent in whether the options would be documented at all. Cut through this gordian knot by linking all APIs that use the secureContext options to the single source of truth about the options.
- Loading branch information
commit bb89227d029d3af3bbf76b08cd4f7a4d90cf8c98
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My tests and reading of code show it not mutually exclusive with key/cert, btw, and it would be quite strange if it was mutually exclusive with ca. I am still extending test suite to confirm this.