Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
9049c1f
tls: introduce `secureContext` for `tls.connect`
indutny Dec 11, 2015
9f0ef5a
doc: fix heading type for v4.6.2 changelog
Nov 8, 2016
1dfb5b5
v8: update make-v8.sh to use git
Nov 1, 2016
620cdc5
tools: fix release script on macOS 10.12
evanlucas Sep 28, 2016
8807981
doc: fix typo in http.md
anu0012 Oct 18, 2016
f472c09
doc: reference signal(7) for the list of signals
emadb Oct 27, 2016
f669a08
src: fix typo rval to value
maasencioh Oct 11, 2016
a7ae887
governance: expand use of CTC issue tracker
Trott Oct 6, 2016
af645a0
doc: explain why GitHub merge button is not used
jalafel Oct 12, 2016
4f8bf1b
doc: explains why Reviewed-By is added in PRs
jalafel Oct 12, 2016
695ee1e
doc: highlight deprecated API in ToC
ilfroloff Sep 2, 2016
4de7a6e
build: fix config.gypi target
danbev Oct 12, 2016
9a192a9
net: fix ambiguity in EOF handling
indutny Oct 12, 2016
132425a
doc: specify that errno is a number, not a string
Oct 10, 2016
f9b24f4
test: use npm sandbox in test-npm-install
joaocgreis Oct 13, 2016
68ccc7a
doc: update reference to list hash algorithms in crypto.md
sstern6 Oct 11, 2016
e564cb6
doc: add ctc-review label information
Trott Oct 13, 2016
3b839d1
doc: remove confusing reference in governance doc
Trott Oct 13, 2016
279e30c
doc: add CTC meeting minutes for 2016-10-12
mhdawson Oct 13, 2016
3cefd65
build: export openssl symbols on windows
bnoordhuis Apr 18, 2016
84849f1
build: export more openssl symbols on Windows
Jul 10, 2016
4238460
lib: remove let from for loops
Sep 30, 2016
9b9762c
streams: fix regression in `unpipe()`
addaleax Oct 18, 2016
d9c3364
test: add regression test for `unpipe()`
Oct 18, 2016
c8dccf2
tools: avoid let in for loops
jalafel Oct 12, 2016
4a6bd86
test: fix flaky test-child-process-fork-dgram
Trott Oct 14, 2016
c94482b
http: 451 status code "Unavailable For Legal Reasons"
mbarinov Dec 21, 2015
bd99b2d
test: checking if error constructor is assert.AssertionError
larissayvette Oct 12, 2016
a038fcc
test: add regression test for instanceof
fhinkel Oct 19, 2016
a64af39
test: remove duplicate required module
Trott Oct 18, 2016
c1e5e66
doc: improve header styling for API docs
Fishrock123 Sep 27, 2016
e9c6aff
doc: add 2016-10-19 CTC meeting minutes
joshgav Oct 19, 2016
1a701f1
doc: add 2016-09-28 CTC meeting minutes
joshgav Oct 27, 2016
8240092
doc: add 2016-10-05 CTC meeting minutes
joshgav Oct 27, 2016
9dad98b
doc: add 2016-10-26 CTC meeting minutes
Trott Oct 28, 2016
d1d207b
doc: add Sakthipriyan to the CTC
rvagg Nov 2, 2016
bf25994
tls: fix leak of WriteWrap+TLSWrap combination
indutny Nov 12, 2016
0f41058
doc: clarify relation between a file and a module
marzelin Oct 11, 2016
f9baa11
tools: remove dangling eslint symlink
sam-github Oct 26, 2016
80a26c7
test: writable stream finished state
Sep 27, 2016
ba4a3ed
test: writable stream ending state
Sep 22, 2016
40ef239
test: writable stream needDrain state
Sep 27, 2016
2b2dde8
doc: add italoacasas to collaborators
Nov 18, 2016
00a1782
doc: update CONTRIBUTING.md to address editing PRs
gibfahn Oct 19, 2016
91fce10
deps: back port OpenBSD fix in c-ares/c-ares
qbit Oct 23, 2016
527db40
test: add coverage for execFileSync() errors
cjihrig Oct 20, 2016
bb2fdf5
build: cherry pick V8 change for windows DLL support
stefanmb Jul 20, 2016
f21c2b9
build: configure --shared
sxa Jul 4, 2016
0138b4d
build: windows sharedlib support
Nov 16, 2016
e97723b
build: abstract out shared library suffix
Jul 12, 2016
12da258
https: fix memory leak with https.request()
imyller Sep 18, 2016
03f7031
test: remove call to `net.Socket.resume()`
ALJCepeda Sep 21, 2016
b3fccc2
test: enable cyrillic punycode test case
bnoordhuis Sep 21, 2016
cec5e36
test: fix test-cluster-worker-init.js flakyness
imyller Sep 21, 2016
f0192ec
src: don't abort when c-ares initialization fails
bnoordhuis Sep 22, 2016
bdb6cf9
win,msi: mark INSTALLDIR property as secure
joaocgreis Sep 26, 2016
347547a
test: expand test coverage for url.js
jun-oka Sep 30, 2016
a3a184d
lib: fix TypeError in v8-polyfill
geek Sep 30, 2016
3919edb
build: don't build icu with -fno-rtti
bnoordhuis Sep 30, 2016
7904066
test: refactor test-net-server-max-connections
Trott Oct 4, 2016
c48c318
doc: change ./node to node in debugger.md
AnnaMag Oct 5, 2016
475fe96
doc: simplify process.memoryUsage() example code
watson Nov 12, 2016
9a02414
zlib: fix raw inflate with custom dictionary
thusoy Sep 20, 2016
748e424
debugger: make listen address configurable
bnoordhuis Oct 10, 2015
524ebfb
doc: child_process .stdio accepts a String type
skovhus Nov 19, 2016
66e26cd
doc: child_process.execSync .stdio default is pipe
skovhus Nov 20, 2016
4c47446
deps: make gtest output tap
bnoordhuis Aug 9, 2016
7c73105
build: run cctests as part of test-ci target
bnoordhuis Aug 10, 2016
eb34f68
deps: revert default gtest reporter change
mscdex Oct 17, 2016
747013b
test: output tap13 instead of almost-tap
jbergstroem Oct 12, 2016
36abbbe
gtest: output tap comments as yamlish
jbergstroem Oct 25, 2016
02e6c84
gitignore: ignore all tap files
jbergstroem Oct 25, 2016
4571c84
dgram: generalized send queue to handle close
mcollina May 30, 2016
a2621a2
test: remove FIXME pummel/test-tls-securepair-client
ALJCepeda Sep 24, 2016
3b448a7
lib: changed var to const in linkedlist
AdriVanHoudt Sep 17, 2016
fafffd4
test: fix test-child-process-fork-regr-gh-2847
santigimeno Oct 6, 2016
fc77cbb
doc: make node(1) more consistent with tradition
strugee Oct 8, 2016
b4353e9
src: fix typo in #endif comment
juanandresnyc Oct 9, 2016
e5d2a95
src: remove out-of-date TODO comment
danbev Oct 10, 2016
51b251d
test: add coverage for spawnSync() killSignal
cjihrig Oct 6, 2016
462c640
doc: fix typo in email address in README
Trott Oct 5, 2016
6d742b3
test: remove err timer from test-http-set-timeout
BethGriggs Oct 24, 2016
9d5e7f5
test: use strict assertions in module loader test
bnoordhuis Oct 24, 2016
533ce48
tools: make --repeat work with -j in test.py
Trott Oct 24, 2016
f18f3b6
util: use template strings
a0viedo Oct 17, 2016
ed31f9c
benchmark: add microbenchmarks for ES Map
rvagg Jul 7, 2016
59d821d
build: use wxneeded on openbsd
qbit Oct 21, 2016
bcd156f
test: refactor test-async-wrap-check-providers
Oct 26, 2016
b0476c5
test: fix flaky test-fs-watch-recursive on OS X
Trott Oct 26, 2016
e08173a
doc: fix outdate ninja link
lovexi Oct 25, 2016
d9955fb
test: add test for HTTP client "aborted" event
kemitchell Jun 22, 2016
5e820ae
doc: update Diagnostics WG info
joshgav Oct 27, 2016
2c75886
test: move timer-dependent test to sequential
Trott Nov 3, 2016
861b689
doc: update GOVERNANCE.md to use "meeting chair"
Trott Nov 3, 2016
d3c25c1
doc: update minute-taking procedure for CTC
Trott Nov 2, 2016
c5181ed
build: reduce noise from doc target
danbev Nov 4, 2016
96bdfae
test: improve test-debugger-util-regression
santigimeno Nov 6, 2016
f6f0b38
events: pass the original listener added by once
davidtaikocha Apr 29, 2016
3b5cede
src: renaming ares_task struct to node_ares_task
danbev Jun 20, 2016
51e09d0
src: normalize malloc, realloc
mhdawson Sep 1, 2016
62e83b3
src: Malloc/Calloc size 0 returns non-null pointer
Trott Sep 17, 2016
9389572
crypto: fix faulty logic in iv size check
bnoordhuis Oct 11, 2016
50a4471
http: fix connection upgrade checks
mscdex Aug 23, 2016
54c38eb
tickprocessor: apply c++filt manually on mac
indutny Sep 10, 2016
b1bd1c4
tools: allow test.py to use full paths of tests
reconbot Nov 19, 2016
9144d37
test: cleanup test-dgram-error-message-address
Goyapa Oct 5, 2016
c1effb1
deps: fix build with libc++ 3.8.0
jbergstroem Nov 23, 2016
cc36a63
test: remove watchdog in test-debug-signal-cluster
Trott Nov 5, 2016
4e73e75
2016-12-06, Version 4.7.0 'Argon' (LTS)
Nov 22, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add 2016-10-05 CTC meeting minutes
PR-URL: #9326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
joshgav authored and Myles Borins committed Nov 15, 2016
commit 824009296a782e36161a613f0f5fb0db850cccfc
311 changes: 311 additions & 0 deletions doc/ctc-meetings/2016-10-05.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,311 @@
# Node Foundation CTC Meeting 2016-10-05

## Links

* **Audio Recording**: TBP
* **GitHub Issue**: [#8915](https://github.com/nodejs/node/issues/8915)
* **Minutes Google Doc**: <https://docs.google.com/document/d/1ZsLMM29guCBPGh7KhuhZEq6YQCKybiTfTUIXajTBalM/>
* _Previous Minutes Google Doc_: <https://docs.google.com/document/d/1-PS20PGCJQIi4_quBHqVgrQNJeJP10NH21wUelcMhfw>


## Present

* Anna Henningsen @addaleax (CTC)
* Bradley Meck @bmeck (observer/GoDaddy/TC39)
* Colin Ihrig @cjihrig (CTC)
* Evan Lucas @evanlucas (CTC)
* Jeremiah Senkpiel @Fishrock123 (CTC)
* Tracy Hinds @hackygolucky (observer/Node.js Foundation)
* Michael Dawson @mhdawson (CTC)
* Julien Gilli @misterdjules (CTC)
* Mikeal Rogers @mikeal (observer/Node.js Foundation)
* Jenn Turner @renrutnnej (observer/Node.js Foundation)
* Rod Vagg @rvagg (CTC)
* Seth Thompson @s3ththompson (observer/Google)
* Myles Borins @TheAlphaNerd (CTC)
* Sakthipriyan Vairamani @thefourtheye (observer)
* Trevor Norris @trevnorris (CTC)
* Rich Trott @Trott (CTC)
* Josh Gavant @joshgav (observer/Microsoft)


## Standup

* Anna Henningsen @addaleax (CTC)
* Nothing noteworthy
* Bradley Meck @bmeck (observer/GoDaddy/TC39)
* Went to TC39, got late linking and re-linking fully discussed
* Working on live named imports talks and spec changes
* Colin Ihrig @cjihrig (CTC)
* Reviewing of issues and PRs.
* Evan Lucas @evanlucas (CTC)
* Worked a little on improving the commit linter
* Submitted a PR improving process.nextTick perf by 10-20% in some cases
* Jeremiah Senkpiel @Fishrock123 (CTC)
* merged existsSync undeprecation
* other PRs & Issues
* Tracy Hinds @hackygolucky (observer/Node.js Foundation)
* Outreachy application drive, issue open in the CTC repo
* Met last week to talk about code & lean @ Austin event
* Michael Dawson @mhdawson (CTC)
* Miscellaneous PR review
* fix a v8 test issue
* ABI Stable API meeting, reviews, discussion
* Closed out PPC migration
* Julien Gilli @misterdjules (CTC)
* Investigated SmartOS-specific issues.
* Mikeal Rogers @mikeal (observer/Node.js Foundation)
* Working on new budget for 2017 for the NF
* @ TC39 last week, very productive, looking for a way to be involved longer-term
* Brian White @mscdex (CTC)
* Continued work on various optimizations in core
* Submitted a few misc. cleanup PRs
* Reviewed PRs, commented on issues
* Jenn Turner @renrutnnej (observer/Node.js Foundation)
* No update, observing
* Rod Vagg @rvagg (CTC)
* Little build of build, little bit of LTS, little bit of NF work
* Seth Thompson @s3ththompson (observer/Google)
* async await on track to ship
* V8 inspector work ongoing
* Steven R Loomis @srl295 (observer/IBM/ICU)
* Regrets for today (and out next week) - ICU 58 will be out in a couple of weeks and will have an updated PR at that time…
* Myles Borins @TheAlphaNerd (CTC)
* v4.x backporting
* define outreachy project
* fix regressions in citgm
* work on new communication plan for LTS dates
* Sakthipriyan Vairamani @thefourtheye (observer)
* was sick for much of the week, so not much to report
* Trevor Norris @trevnorris (CTC)
* Fix performance regressions from async hooks
* Almost finished bringing PR compliant with EP. Soon tests and proper API documentation will follow.
* Engaged with the V8 team regarding the MicrotaskQueue API (https://bugs.chromium.org/p/v8/issues/detail?id=4643#c19)
* Rich Trott @Trott (CTC)
* CTC meeting rotation proposal
* 2FA for Collaborators
* miscellaneous issue tracker/commit activity
* Josh Gavant @joshgav (observer)
* time away
* diagnostics WG meeting


## Agenda

Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/node

* doc: add supported platforms list [#8922](https://github.com/nodejs/node/pull/8922)
* Intl: Consider deprecating Intl.v8BreakIterator [#8865](https://github.com/nodejs/node/issues/8865)
* net: multiple listen() events fail silently [#8419](https://github.com/nodejs/node/pull/8419)

### nodejs/CTC

* Scheduling Meetings [#14](https://github.com/nodejs/CTC/issues/14)


## Previous Meeting Review

* Scheduling Meetings [#14](https://github.com/nodejs/CTC/issues/14)
* meta: update NODE_MODULE_VERSION to 51 [#8808](https://github.com/nodejs/node/pull/8808)
* If there are objections raise them in the issue, otherwise ready to merge.
* General v7.0.0 / v6 LTS Planning / Discussion


## Minutes

### doc: add supported platforms list [#8922](https://github.com/nodejs/node/pull/8922)

@johanbergstrom put this together in collaboration with libuv and v8 teams.

@rvagg: Has everyone reviewed that would like to?

We rely on a few dependencies that make us who we are — most importantly V8 and libuv. We therefore need to adopt their supported platforms and potentially add to their lists based on test and/or release coverage.

@trott: Do we mean that we support whatever they support?

@Fishrock123: Could be clarified. Intent is that we must start with what they offer and anything additional falls to us (Node).

@rvagg: Our supported platform list is narrower than that of libuv and v8.

@?: It should say we’re a subset due to the constraints.

@rvagg: Removing that might be the way to go.

Any objections to list as it stands?

Applies to v6, probably the same for v7. Will need to be changed for v4.

If there are concerns, raise in issue.

**Next steps**:

* Raise any concerns in issue.

---

### Intl: Consider deprecating Intl.v8BreakIterator [#8865](https://github.com/nodejs/node/issues/8865)

Want to move to a different API: `Intl.Segmentor`, so want to deprecate this one.

@mikeal: We need to discourage community from using this API so we can move to a more standards-compliant implementation.

@rvagg: We expose this API because V8 exposes it.

@bmeck: APIs exposed by V8 can be removed…

@rvagg: New API is before TC-39, could take a while. Also, what is the timeframe for removal?

Is it possible this will be removed in 5.5 or 5.6, which may land in Node v7.x, in which case it would be a breaking change we’d have to polyfill.

Or will it be removed later and we can include it in Node v8.x.

@mikeal: V8 (Daniel) wants to remove this as soon as possible, but depends on TC-39.

@bmeck: Also some small percentage of web uses this so not able to completely remove yet anyway.

@seththompson: We wait till stage 3 at TC-39 to implement. As far as removing v8BreakIterator, we don’t necessarily rely on usage.

Will investigate this further with Daniel.

@rvagg: No problem with removing it, but need a signal as to when it will be removed.

@seththompson: Dan is out of office through next week.

**Next steps**:

* Continue discussion in GitHub.

---

### net: multiple listen() events fail silently [#8419](https://github.com/nodejs/node/pull/8419)

see also: <https://github.com/nodejs/node/pull/8294>

@jasnell added this item, would be a semver-major change, can it be landed in v7.

@rvagg: Adds error message when `.listen()` is called twice, EADDRINUSE.

@addaleax: (#8294)[https://github.com/nodejs/node/pull/8294] documented that .listen() twice restarts the server. Does that conflict with this?

@Fishrock123: When `close()` is called it resets the listen listener to `false`.

@rvagg: Is this the only way to close?

@addaleax: Might be…

@rvagg: Will keep on agenda for James to discuss.

@Fishrock123: Is anyone opposed to this?

@evanlucas: Have we tested against the ecosystem?

No, but it’s a poor usage anyway.

@trott: delay until next week when James is here.

@trevnorris: If you run this twice on the same server object, it overwrites the `_handle` property, orphaning the original handle.

@mhdawson: Do they get a new handle to use?

@trott: Put this into the issue.

**Next steps**:

* Discuss again next week.

---

### Scheduling Meetings [#14](https://github.com/nodejs/CTC/issues/14)

@trott: All possibilities are bad. Choosing the best of bad options. Hope to give proposed schedule a shot for 4 weeks and then evaluate. Or should we shoot this down and move on?

@rvagg: To start next week, Oct 12?

@trott: Yes.

@rvagg: Any objections to next week: UTC 4:00pm, US Pacific 9am, US East 12 noon.

Better for Europe and India.

No.

Next steps:

* Do next week at new time.

---

### General v7.0.0 / v6 LTS Planning / Discussion

LTS group agreed to put out v6 LTS week of 10/17.

Week after would be v7 final.

@thealphanerd: We should do a release the week before v6 LTS to include all semver-minor changes we want in.

@Fishrock123 will manage this release next week (10/10).

@rvagg will manage v6 LTS the week after (10/17).

@rvagg: What is status on V8 5.4 for 10/18?

@seththompson: @ofrobots to confirm, no known problems.

@rvagg: Still looking for someone to handle backports and releases for v6 LTS.

@Fishrock123: We could switch Myles to v6 and someone else can pick up v4.

@thealphanerd: As long as v4 is still “active” we have to go through everything. Some discussion of how to automate process.

There will be more backports to v6, but also that stuff will be a lot clearer, if it can be backported.

Would be good to come up with a better process for how things end up in staging. Instead of getting everything in there in the last minute.

@Fishrock123: I disagree that if v4 is active it needs to have the same amount of activity all the way through. There has been an understanding that it would get more and more difficult to backport features, focus only on backporting security fixes.

@thealphanerd: I found non-trivial number of items which would’ve been missed by automation.

I’m a little bit uncomfortable with not auditing everything. Things that would get missed are more important than they sometimes seem.

Myles, Evan, and Jeremiah to discuss tooling to help make auditing less work.

@rvagg: Need to resolve Intl.v8BreakIterator for v7 - if we need to deprecate or remove it would be good to do so now.

@SethThompson: Plan is to not deprecate anything until Intl.Segmentor reaches more conclusiveness in TC-39. But team would be fine if Node deprecates sooner.

Current open issues for v7: https://github.com/nodejs/node/milestone/15

@rvagg: We won’t have OpenSSL 1.1.0 in Node in the near future, but it may be possible to compile against it. This isn’t a blocker for v7, doesn’t require semver-major.

@rvagg: Should we ship another version of 0.10 with npm updated to include updated license? Comment in LTS WG.

---

## Q/A on public channels

Alex: Can we get a comment on stability of v6 at this point?

@rvagg: We’ll have a standard v6 release next Tuesday, and the following Tuesday we’ll drop to LTS and stability push will start. Expect it to be as stable as the v4 releases.

If you’re planning to move to v6 LTS, it’s worth testing now.

@Fishrock123: Not many new features in next week’s v6.x.x release. Some regressions early in v6 lifecycle, none now.

@evanlucas: Regression in inspector.

@rvagg: Inspector is still marked experimental for now. That may change in the v6 lifetime. But for now it shouldn’t be treated as stable as the other features.

---

## Upcoming Meetings

* CTC: 2016-10-12, 9am Pacific
* TSC: 2016-10-06, 1pm Pacific
* Build: 2016-10-11
* Diagnostics: first week of November
* Benchmarking:
* LTS: 2016-10-17
* Post-Mortem:
* API: