Skip to content

Symbol key props visible in inspection by default #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mightyiam wants to merge 5 commits into from
Closed

Symbol key props visible in inspection by default #9726

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
903f353
Symbol key props visible in inspection by default
mightyiam Nov 21, 2016
192d79a
test/parallel/test-util-inspect: const UTC -> const UIC
mightyiam Nov 22, 2016
3ace6a9
Excl. non-enumerable property symbols from inspection by default
mightyiam Nov 24, 2016
8e73c95
lib/util: use const for symbolKeys & enumSymbolKeys
mightyiam Nov 24, 2016
3cbd847
lib/util: fix indentation of enumSymbolKeys's filter call
mightyiam Nov 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib/util: use const for symbolKeys & enumSymbolKeys
  • Loading branch information
@mightyiam
mightyiam committed Nov 24, 2016
commit 8e73c9501c0a4e88fbfd933ddc6ef1ebc0b50ad3
4 changes: 2 additions & 2 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ function formatValue(ctx, value, recurseTimes) {
// Look up the keys of the object.
var keys = Object.keys(value);
var visibleKeys = arrayToHash(keys);
Copy link
Copy Markdown
Contributor Author

@mightyiam mightyiam Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what goes on with keys vs. visibleKeys, yet, this seems to work.

var symbolKeys = Object.getOwnPropertySymbols(value);
var enumSymbolKeys = symbolKeys
const symbolKeys = Object.getOwnPropertySymbols(value);
const enumSymbolKeys = symbolKeys
.filter((key) => value.propertyIsEnumerable(key));
Copy link
Copy Markdown
Member

@addaleax addaleax Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we generally indent statement continuations by 4 spaces, not 2

keys = keys.concat(enumSymbolKeys);

Expand Down