Skip to content

build: Make configure file parseable on python3 #9657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kalrover wants to merge 5 commits into from
Closed

build: Make configure file parseable on python3 #9657

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1fc8aae
build: Make configure file parseable on python3
kalrover Nov 17, 2016
6d786b5
Fix message & long line
kalrover Nov 18, 2016
6f82f8b
Fix try statement
kalrover Nov 21, 2016
aff20c6
Remove redundant parentheses
kalrover Nov 21, 2016
2303ff7
Check python 2.6 or 2.7
kalrover Nov 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix message & long line
  • Loading branch information
@kalrover
kalrover committed Nov 24, 2016
commit 6d786b54f0457b43c9a360fc798a774a6720e50f
5 changes: 3 additions & 2 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import sys
if sys.version_info >= (3, 0):
Copy link
Copy Markdown
Contributor Author

@kalrover kalrover Nov 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about if sys.version_info[0] == 2 and sys.version_info[1] in [6, 7] ?

sys.stdout.write("Python 3.x is not compatible at this time\n")
sys.stdout.write("Python 3 is not supported, please use Python 2.6 or 2.7\n")
sys.exit(1)

import errno
Expand Down Expand Up @@ -1154,7 +1154,8 @@ def configure_intl(o):
os.rename(tmp_icu, icu_full_path)
shutil.rmtree(icu_tmp_path)
else:
print(' Error: --with-icu-source=%s did not result in an "icu" dir.' % with_icu_source)
print(' Error: --with-icu-source=%s did not result in an "icu" dir.' % \
with_icu_source)
shutil.rmtree(icu_tmp_path)
sys.exit(1)

Expand Down