Skip to content

doc: changed order of invocations in example. #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atripes wants to merge 1 commit into from
Closed

doc: changed order of invocations in example. #9614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: changed order of invocations in example. 
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.
  • Loading branch information
atrioom authored Nov 15, 2016
commit ef7e3ac432853871c96dd7db642a1700c95ba32b
3 changes: 2 additions & 1 deletion doc/api/https.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,12 @@ var req = https.request(options, (res) => {
process.stdout.write(d);
});
});
req.end();

req.on('error', (e) => {
console.error(e);
});
req.end();

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Nov 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this blank line.

```

The options argument has the following options
Expand Down