Skip to content

Backport of #9098: test: fix flaky test-child-process-fork-dgram #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

Backport of #9098: test: fix flaky test-child-process-fork-dgram #9558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-child-process-fork-dgram 
`test-child-process-fork-dgram` is unreliable on some platforms,
especially FreeBSD and AIX within the project's continuous integration
testing. It has also been observed to be flaky on macos.

* Confirm child has received the server before sending packets
* Close the server instance on the parent or child after receiving a

Refs: #8697
Fixes: #8949
Fixes: #8271
PR-URL: #9098
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 12, 2016
commit 0d314aaaaf7f4e8ce2ef04e404ee39fb68712563
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,3 @@ test-fs-watch-encoding : FAIL, PASS
#covered by https://github.com/nodejs/node/issues/3796
# but more frequent on AIX ?
test-debug-signal-cluster : PASS, FLAKY

#covered by https://github.com/nodejs/node/issues/8271
test-child-process-fork-dgram : PASS, FLAKY
99 changes: 42 additions & 57 deletions test/parallel/test-child-process-fork-dgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,101 +4,86 @@
* sending a fd representing a UDP socket to the child and sending messages
* to this endpoint, these messages are distributed to the parent and the
* child process.
*
* Because it's not really possible to predict how the messages will be
* distributed among the parent and the child processes, we keep sending
* messages until both the parent and the child received at least one
* message. The worst case scenario is when either one never receives
* a message. In this case the test runner will timeout after 60 secs
* and the test will fail.
*/

const common = require('../common');
var dgram = require('dgram');
var fork = require('child_process').fork;
var assert = require('assert');
const dgram = require('dgram');
const fork = require('child_process').fork;
const assert = require('assert');

if (common.isWindows) {
common.skip('Sending dgram sockets to child processes is ' +
'not supported');
common.skip('Sending dgram sockets to child processes is not supported');
return;
}

var server;
if (process.argv[2] === 'child') {
process.on('message', function removeMe(msg, clusterServer) {
if (msg === 'server') {
server = clusterServer;

server.on('message', function() {
process.send('gotMessage');
});

} else if (msg === 'stop') {
server.close();
process.removeListener('message', removeMe);
}
let childServer;

process.once('message', function(msg, clusterServer) {
childServer = clusterServer;

childServer.once('message', function() {
process.send('gotMessage');
childServer.close();
});

process.send('handleReceived');
});

} else {
server = dgram.createSocket('udp4');
var client = dgram.createSocket('udp4');
var child = fork(__filename, ['child']);
const parentServer = dgram.createSocket('udp4');
const client = dgram.createSocket('udp4');
const child = fork(__filename, ['child']);

var msg = Buffer.from('Some bytes');
const msg = Buffer.from('Some bytes');

var childGotMessage = false;
var parentGotMessage = false;

server.on('message', function(msg, rinfo) {
parentServer.once('message', function(msg, rinfo) {
parentGotMessage = true;
parentServer.close();
});

server.on('listening', function() {
child.send('server', server);
parentServer.on('listening', function() {
child.send('server', parentServer);

child.once('message', function(msg) {
child.on('message', function(msg) {
if (msg === 'gotMessage') {
childGotMessage = true;
} else if (msg = 'handlReceived') {
sendMessages();
}
});

sendMessages();
});

var sendMessages = function() {
var timer = setInterval(function() {
client.send(
msg,
0,
msg.length,
server.address().port,
'127.0.0.1',
function(err) {
if (err) throw err;
}
);
const sendMessages = function() {
const serverPort = parentServer.address().port;

const timer = setInterval(function() {
/*
* Both the parent and the child got at least one message,
* test passed, clean up everyting.
*/
if (parentGotMessage && childGotMessage) {
clearInterval(timer);
shutdown();
client.close();
} else {
client.send(
msg,
0,
msg.length,
serverPort,
'127.0.0.1',
function(err) {
if (err) throw err;
}
);
}

}, 1);
};

var shutdown = function() {
child.send('stop');

server.close();
client.close();
};

server.bind(0, '127.0.0.1');
parentServer.bind(0, '127.0.0.1');

process.once('exit', function() {
assert(parentGotMessage);
Expand Down