Skip to content

doc: clarify the callback arguments of dns.resolve #9532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind wants to merge 6 commits into from
Closed

doc: clarify the callback arguments of dns.resolve #9532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f690863
doc: clarify dns.resolve API
silverwind Dec 9, 2016
494bfc0
lowercase primitives
silverwind Apr 12, 2017
17adad8
tools: handle tables in doctool
silverwind Apr 12, 2017
d7d220c
fix header replacements
silverwind Apr 12, 2017
3a1292d
refactor token parsers slightly, add {Array} in table header
silverwind Apr 12, 2017
50c4789
rename addresses to records, consolidate paragraphs
silverwind Apr 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor token parsers slightly, add {Array} in table header
  • Loading branch information
@silverwind
silverwind committed Apr 12, 2017
commit 3a1292de7d04fb6ab41a25bb2c25763732b00560
2 changes: 1 addition & 1 deletion doc/api/dns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ added: v0.1.27
Uses the DNS protocol to resolve a hostname (e.g. `'nodejs.org'`) into an
array of the resource records, specified by `rrtype` (resource record type):

| `rrtype` | Return array contains | Result type | Shorthand method |
| `rrtype` | Return {Array} contains | Result type | Shorthand method |
|-----------|--------------------------------|-------------|--------------------------|
| `'A'` | IPv4 addresses (default) | {string} | [`dns.resolve4()`][] |
| `'AAAA'` | IPv6 addresses | {string} | [`dns.resolve6()`][] |
Expand Down
34 changes: 17 additions & 17 deletions tools/doc/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,26 +192,26 @@ function replaceInText(text) {
// for example, link man page references to the actual page
function parseText(lexed) {
lexed.forEach(function(tok) {
if (tok.text && tok.type !== 'code') {
tok.text = replaceInText(tok.text);
}
if (tok.type === 'table') {
if (tok.cells) {
tok.cells.forEach((row, x) => {
row.forEach((_, y) => {
if (tok.cells[x] && tok.cells[x][y]) {
tok.cells[x][y] = replaceInText(tok.cells[x][y]);
}
});
});
}

if (tok.cells) {
tok.cells.forEach((row, x) => {
row.forEach((_, y) => {
if (tok.cells[x] && tok.cells[x][y]) {
tok.cells[x][y] = replaceInText(tok.cells[x][y]);
if (tok.header) {
tok.header.forEach((_, i) => {
if (tok.header[i]) {
tok.header[i] = replaceInText(tok.header[i]);
}
});
});
}

if (tok.header) {
tok.headers.forEach((_, i) => {
if (tok.headers[i]) {
tok.headers[i] = replaceInText(tok.headers[i]);
}
});
}
} else if (tok.text && tok.type !== 'code') {
tok.text = replaceInText(tok.text);
}
});
}
Expand Down