Skip to content

test: refactor inspector-helper.js #9499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor inspector-helper.js #9499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor inspector-helper.js 
There are two instances of `setTimeout()` called without a duration in
`inspector-helper.js`. Change to `setImmediate()` for clarity that it
isn't a mistake.
  • Loading branch information
@Trott
Trott committed Nov 7, 2016
commit 0686086e2c2c53e2507a88112d565fe9863c933a
4 changes: 2 additions & 2 deletions test/inspector/inspector-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ TestSession.prototype.expectStderrOutput = function(regexp) {

TestSession.prototype.runNext_ = function() {
if (this.task_) {
setTimeout(() => {
setImmediate(() => {
this.task_(() => {
this.task_ = this.task_.next_;
this.runNext_();
Expand Down Expand Up @@ -338,7 +338,7 @@ Harness.prototype.addStderrFilter = function(regexp, callback) {
};

Harness.prototype.run_ = function() {
setTimeout(() => {
setImmediate(() => {
this.task_(() => {
this.task_ = this.task_.next_;
if (this.task_)
Expand Down