Skip to content

test: remove watchdog in test-debug-signal-cluster #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: remove watchdog in test-debug-signal-cluster #9476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove watchdog in test-debug-signal-cluster 
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.
  • Loading branch information
@Trott
Trott committed Nov 5, 2016
commit ae7686fb4db1aa0f82d0cc854dd444ecf905cfe4
4 changes: 0 additions & 4 deletions test/parallel/test-debug-signal-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ function onNoMoreDebuggerAgentsOutput() {
process.exit();
}

setTimeout(function testTimedOut() {
common.fail('test timed out');
}, common.platformTimeout(4000)).unref();

process.on('exit', function onExit() {
// Kill processes in reverse order to avoid timing problems on Windows where
// the parent process is killed before the children.
Expand Down