Skip to content

test: increase test-net-GH-5504 timeout #9444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: increase test-net-GH-5504 timeout #9444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increate test-net-GH-5504 timeout 
test-net-GH-5504 failed on smartos14-64 in CI. The internal test timeout
expired. It is currently 2 seconds. That appears to be somewhat
arbitrary. It may be possible to rewrite the test without the timer.  As
an immediate workaround, increase the timeout to 5 seconds.
  • Loading branch information
@Trott
Trott committed Nov 4, 2016
commit 24af7caf94fc7c8e19c1e7c630acfbae71908c3f
6 changes: 4 additions & 2 deletions test/sequential/test-net-GH-5504.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
'use strict';
var common = require('../common');

// this test only fails with CentOS 6.3 using kernel version 2.6.32
// https://github.com/nodejs/node-v0.x-archive/issues/5504
//
// This test only fails with CentOS 6.3 using kernel version 2.6.32
// On other linuxes and darwin, the `read` call gets an ECONNRESET in
// that case. On sunos, the `write` call fails with EPIPE.
//
Expand Down Expand Up @@ -54,7 +56,7 @@ function parent() {
setTimeout(function() {
throw new Error('hang');
});
}, common.platformTimeout(2000)).unref();
}, common.platformTimeout(5000)).unref();

var s = spawn(node, [__filename, 'server'], {
env: Object.assign(process.env, {
Expand Down