Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7.1.0 proposal - 2016-11-08 #9438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v7.1.0 proposal - 2016-11-08 #9438
Changes from 1 commit
c6e429a362c3078b53f3c9e753baf2a3b244be1ba5204461921ba3e3c2311302e7b07806b41409372aee63ef099d573acfd1c32aa44427cc60a5b51ce00a9defb62aaa39b98e5e138fedeef2f653520f0d24bd2085a9295c342bda08e12c7a5c62cb0939edd57c0a9b106d719939d102fc9e6a3f39eb05bdad1e22ad81edd2e788282119041c59cef0b9d80a4f0596f3f904810ce0abfa0074e2a3f68549940666c23ece7d49d990c745890d6f688a248a320c9b67c6edd89260ab008e212da12f7d84810f871e16f35e446c9e4fd5ab172e8b7ce8bbd9cb40fab8eb610374634e3731c411b13301b626ad8eaa147f1a40d31690a63550419827000e3d1766feeabab3dbeadd3225a9df3d4a8290c236d1e451022d09eb9c071836a5bfefa6c554f09ff69e38d4b50957b0e937d12ed293af9453ed3f80ab51db71e696bc31c3487ba8295d8c2fab3c60461d2513da40dafdb7baac4af2b1ef638f1f00dfc70c96a9d9ea814bb9d2190aac7cbc2d1c9ed8df17675a4b24c4132ef640baf6eb6816b08308644792f81109d0b6e1eb59ceec5200325339173b0880a3a9673daf116File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There is no point in trying to search for files in a directory that we know does not exist, so stop doing that. Reduces the total number of stat(2) calls and the number of stat(2) misses on a medium-sized application by about 21% and 29% respectively. Reduces the total number of package.json open(2) calls and the number of open(2) misses by about 21% and 93% (!) respectively. Before: % time seconds usecs/call calls errors syscall ------ ----------- ----------- --------- --------- ---------------- 50.93 0.178419 38 4702 lstat 29.08 0.101875 36 2800 2010 stat 11.36 0.039796 43 932 215 open 5.39 0.018897 34 550 fstat 3.24 0.011337 34 336 pread ------ ----------- ----------- --------- --------- ---------------- 100.00 0.350324 9320 2225 total After: % time seconds usecs/call calls errors syscall ------ ----------- ----------- --------- --------- ---------------- 55.49 0.176638 38 4702 lstat 24.76 0.078826 35 2225 1435 stat 10.19 0.032434 44 733 16 open 6.19 0.019719 36 550 fstat 3.37 0.010723 32 336 pread ------ ----------- ----------- --------- --------- ---------------- 100.00 0.318340 8546 1451 total PR-URL: #9196 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing