Skip to content

test: move timer-dependent test to sequential #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: move timer-dependent test to sequential #9431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: move timer-dependent test to sequential 
Timer-dependent tests fail frequently on certain platforms in CI when
run in parallel with other tests, likely due to competition for
resources. Move test-repl-timeout-throw to sequential to avoid this
problem. Also did some minor refactoring (var->const and more use of
assert.strictEqual of looser assertions).
  • Loading branch information
@Trott
Trott committed Nov 3, 2016
commit b59784e8137981b2872ab38c14481adf76c63de4
10 changes: 5 additions & 5 deletions test/parallel/test-repl-timeout-throw.js → test/sequential/test-repl-timeout-throw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use strict';
const common = require('../common');
var assert = require('assert');
const assert = require('assert');

var spawn = require('child_process').spawn;
const spawn = require('child_process').spawn;

var child = spawn(process.execPath, [ '-i' ], {
const child = spawn(process.execPath, [ '-i' ], {
stdio: [null, null, 2]
});

Expand Down Expand Up @@ -52,8 +52,8 @@ child.stdout.once('data', function() {
});

child.on('close', function(c) {
assert(!c);
assert.strictEqual(c, 0);
// make sure we got 3 throws, in the end.
var lastLine = stdout.trim().split(/\r?\n/).pop();
assert.equal(lastLine, '> 3');
assert.strictEqual(lastLine, '> 3');
});