Skip to content

zlib: name every function #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solebox wants to merge 2 commits into from
Closed

zlib: name every function #9389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57c1f8
zlib: name every function
solebox Oct 31, 2016
0aade16
zlib: name every function
solebox Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
zlib: name every function 
Ref: #8913
  • Loading branch information
@solebox
solebox committed Oct 31, 2016
commit b57c1f84623214d54b2b558cb813efcc147790fb
7 changes: 4 additions & 3 deletions lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function Zlib(opts, mode) {

var self = this;
this._hadError = false;
this._handle.onerror = function(message, errno) {
this._handle.onerror = (message, errno) => {
Copy link
Copy Markdown
Member

@jasnell jasnell Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change this one to an arrow function. There's really no point in doing so here. I would just add a name to the existing function

// there is no way to cleanly recover.
// continuing only obscures problems.
_close(self);
Expand Down Expand Up @@ -402,7 +402,7 @@ Zlib.prototype.params = function(level, strategy, callback) {

if (this._level !== level || this._strategy !== strategy) {
var self = this;
this.flush(constants.Z_SYNC_FLUSH, function() {
this.flush(constants.Z_SYNC_FLUSH, function flushCallback() {
assert(self._handle, 'zlib binding closed');
self._handle.params(level, strategy);
if (!self._hadError) {
Expand Down Expand Up @@ -443,7 +443,8 @@ Zlib.prototype.flush = function(kind, callback) {
this.once('end', callback);
} else if (ws.needDrain) {
if (callback) {
this.once('drain', () => this.flush(kind, callback));
const drainHandler = () => this.flush(kind, callback);
this.once('drain', drainHandler);
}
} else {
this._flushFlag = kind;
Expand Down