Skip to content

name net anonymous functions #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvsousalima wants to merge 2 commits into from
Closed

name net anonymous functions #9357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2321c4c
net: name anonymous functions in net module
pvsousalima Oct 29, 2016
6ce4862
net: name anonymous functions in net module
pvsousalima Oct 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: name anonymous functions in net module 
changing the name proposed to the anonymous function
as stated on #9357 (comment)
  • Loading branch information
@pvsousalima
pvsousalima committed Nov 1, 2016
commit 6ce4862ca1cb500abd6b2ec54ae8f5e1344cad61
2 changes: 1 addition & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,7 +1389,7 @@ Server.prototype.listen = function() {
};

function lookupAndListen(self, port, address, backlog, exclusive) {
require('dns').lookup(address, function emitLookup(err, ip, addressType) {
require('dns').lookup(address, function doListening(err, ip, addressType) {
if (err) {
self.emit('error', err);
} else {
Expand Down