Skip to content

url: refactor truncating long hostname #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jun-oka wants to merge 4 commits into from
Closed

url: refactor truncating long hostname #9292

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
089c3e5
url: stop truncating long hostname
jun-oka Dec 1, 2016
835a097
test: refactor fix some typo, put parents for groups and correct for …
jun-oka Dec 23, 2016
ac7c6be
url: correct variable name, and re-prioritize conditionals to valid h…
jun-oka Dec 24, 2016
782e351
url: add missing space
jun-oka Dec 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: refactor fix some typo, put parents for groups and correct for … 
…loop condition
  • Loading branch information
@jun-oka
jun-oka committed Dec 24, 2016
commit 835a097b711d2e3cbc74b0e760784e13d2d60d25
10 changes: 5 additions & 5 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,19 +408,19 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
};

function validateHostname(self, rest, hostname) {
for (var i = 0; i <= hostname.length; ++i) {
for (var i = 0; i < hostname.length; ++i) {
const code = hostname.charCodeAt(i);
const isVc = code === 46/*.*/ ||
code >= 48/*0*/ && code <= 57/*9*/ ||
code >= 97/*a*/ && code <= 122/*\z*/ ||
(code >= 48/*0*/ && code <= 57/*9*/) ||
(code >= 97/*a*/ && code <= 122/*z*/) ||
code === 45/*-*/ ||
code >= 65/*A*/ && code <= 90/*Z*/ ||
(code >= 65/*A*/ && code <= 90/*Z*/) ||
code === 43/*+*/ ||
code === 95/*_*/||
code > 127;

// Invalid host character
if (!isVc && i !== hostname.length) {
if (!isVc) {
self.hostname = hostname.slice(0, i);
return '/' + hostname.slice(i) + rest;
}
Expand Down