Skip to content

inspector: add contexts when using vm module#9272

Closed
bmeck wants to merge 4 commits intonodejs:masterfrom
bmeck:inspect-contexts
Closed

inspector: add contexts when using vm module#9272
bmeck wants to merge 4 commits intonodejs:masterfrom
bmeck:inspect-contexts

Conversation

@bmeck
Copy link
Copy Markdown
Member

@bmeck bmeck commented Oct 25, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

Tracks all vm module contexts for usage in v8_inspector. These are tracked even when the inspector is not running so that they are visible when the inspector is started up.

Fixes: #7593

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v8_inspector: Support the V8 debugger from within VM contexts