Skip to content

os: name every function OS module #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lprasanthi wants to merge 1 commit into from
Closed

os: name every function OS module #9250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
os: name every anonymous function in OS module 
There are too many anonymous functions in the source code which makes
the debugging frustrating.

We are fixing this issue by naming every anonymous function in all the
modules.As part of which,this commit contains changes to os module
  • Loading branch information
@lprasanthi
lprasanthi committed Oct 24, 2016
commit 9e63b3bea176c0a6e3ac8e9ef717204b60f4b680
10 changes: 5 additions & 5 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ Object.defineProperty(exports, 'constants', {
value: constants
});

exports.arch = function() {
exports.arch = function arch() {
return process.arch;
};

exports.platform = function() {
exports.platform = function platform() {
return process.platform;
};

exports.tmpdir = function() {
exports.tmpdir = function tmpdir() {
var path;
if (isWindows) {
path = process.env.TEMP ||
Expand Down Expand Up @@ -62,6 +62,6 @@ exports.getNetworkInterfaces = internalUtil.deprecate(function() {
exports.EOL = isWindows ? '\r\n' : '\n';

if (binding.isBigEndian)
exports.endianness = function() { return 'BE'; };
exports.endianness = function endianness() { return 'BE'; };
else
exports.endianness = function() { return 'LE'; };
exports.endianness = function endianness() { return 'LE'; };