Skip to content

url: name anonymous functions in url #9225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvsousalima wants to merge 1 commit into from
Closed

url: name anonymous functions in url #9225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
url: name anonymous functions in url 
name anonymous functions in url module
the changes are related to commits ef030da and accf410
which are naming anonymous functions to standardize the code
and help debugging, also with Ref: #8913
  • Loading branch information
@pvsousalima
pvsousalima committed Oct 21, 2016
commit a285148bfba05166e033d52379bdbb1e55f3d5e4
10 changes: 5 additions & 5 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function urlParse(url, parseQueryString, slashesDenoteHost) {
return u;
}

Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
if (typeof url !== 'string') {
throw new TypeError('Parameter "url" must be a string, not ' + typeof url);
}
Expand Down Expand Up @@ -555,7 +555,7 @@ function urlFormat(obj) {
return obj.format();
}

Url.prototype.format = function() {
Url.prototype.format = function format() {
var auth = this.auth || '';
if (auth) {
auth = encodeAuth(auth);
Expand Down Expand Up @@ -640,7 +640,7 @@ function urlResolve(source, relative) {
return urlParse(source, false, true).resolve(relative);
}

Url.prototype.resolve = function(relative) {
Url.prototype.resolve = function resolve(relative) {
return this.resolveObject(urlParse(relative, false, true)).format();
};

Expand All @@ -649,7 +649,7 @@ function urlResolveObject(source, relative) {
return urlParse(source, false, true).resolveObject(relative);
}

Url.prototype.resolveObject = function(relative) {
Url.prototype.resolveObject = function resolveObject(relative) {
if (typeof relative === 'string') {
var rel = new Url();
rel.parse(relative, false, true);
Expand Down Expand Up @@ -927,7 +927,7 @@ Url.prototype.resolveObject = function(relative) {
return result;
};

Url.prototype.parseHost = function() {
Url.prototype.parseHost = function parseHost() {
var host = this.host;
var port = portPattern.exec(host);
if (port) {
Expand Down