Skip to content

repl: don’t write to input stream in editor mode #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

repl: don’t write to input stream in editor mode #9207

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c9d87
repl: make `key` of `repl.write()` optional always
addaleax Oct 20, 2016
d197827
[squash] use regex for control code + prompt stripping
addaleax Oct 20, 2016
979528d
repl: don’t write to input stream in editor mode
addaleax Oct 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] use regex for control code + prompt stripping
  • Loading branch information
@addaleax
addaleax committed Oct 20, 2016
commit d19782764698a431e0558a56bda98455d7c8f884
10 changes: 3 additions & 7 deletions test/parallel/test-repl-.editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const repl = require('repl');
// \u001b[0J - Clear screen
// \u001b[3G - Moves the cursor to 3rd column
const terminalCode = '\u001b[1G\u001b[0J> \u001b[3G';
const terminalCodeRegex = new RegExp(terminalCode.replace(/\[/g, '\\['), 'g');

function run({input, output, event, checkTerminalCodes = true}) {
const stream = new common.ArrayStream();
Expand All @@ -33,13 +34,8 @@ function run({input, output, event, checkTerminalCodes = true}) {
replServer.close();

if (!checkTerminalCodes) {
while (found.includes(terminalCode))
found = found.replace(terminalCode, '');
while (expected.includes(terminalCode))
expected = expected.replace(terminalCode, '');

found = found.replace(/\n/g, '');
expected = expected.replace(/\n/g, '');
found = found.replace(terminalCodeRegex, '').replace(/\n/g, '');
expected = expected.replace(terminalCodeRegex, '').replace(/\n/g, '');
}

assert.strictEqual(found, expected);
Expand Down