Skip to content

smalloc: cleanup & refactoring #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkurchatkin wants to merge 4 commits into from
Closed

smalloc: cleanup & refactoring #920

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08ed231
smalloc: consistent error messages
vkurchatkin Feb 22, 2015
2c94f6e
smalloc: validate arguments in js
vkurchatkin Feb 22, 2015
3acee6e
smalloc: export constants from C++
vkurchatkin Feb 22, 2015
1b3d362
smalloc: add asserts
vkurchatkin Mar 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
smalloc: add asserts
  • Loading branch information
@vkurchatkin
vkurchatkin committed Mar 3, 2015
commit 1b3d36260d67abe939eab56baa3bfb0a94d6600e
11 changes: 11 additions & 0 deletions src/smalloc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,15 @@ size_t ExternalArraySize(enum ExternalArrayType type) {
void CopyOnto(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ASSERT(args[0]->IsObject());
ASSERT(args[2]->IsObject());

Local<Object> source = args[0].As<Object>();
Local<Object> dest = args[2].As<Object>();

ASSERT(source->HasIndexedPropertiesInExternalArrayData());
ASSERT(dest->HasIndexedPropertiesInExternalArrayData());

size_t source_start = args[1]->Uint32Value();
size_t dest_start = args[3]->Uint32Value();
size_t copy_length = args[4]->Uint32Value();
Expand Down Expand Up @@ -270,8 +276,12 @@ void SliceOnto(const FunctionCallbackInfo<Value>& args) {
void Alloc(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ASSERT(args[0]->IsObject());

Local<Object> obj = args[0].As<Object>();

ASSERT(!obj->HasIndexedPropertiesInExternalArrayData());

size_t length = args[1]->Uint32Value();
enum ExternalArrayType array_type;

Expand Down Expand Up @@ -410,6 +420,7 @@ void Alloc(Environment* env,

void HasExternalData(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
ASSERT(args[0]->IsObject());
args.GetReturnValue().Set(HasExternalData(env, args[0].As<Object>()));
}

Expand Down