Skip to content

tools: replace custom lint rule for getter/setter #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

tools: replace custom lint rule for getter/setter #9194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: replace custom lint rule for getter/setter 
Replace custom `no-definegetter-definesetter` lint rule with ESLint's
built-in `no-restricted-properties`.

Refs: #9112 (review)
  • Loading branch information
@Trott
Trott committed Oct 19, 2016
commit 6dc7a4ba3adf5e6c2aea180022b6d4d15eefa79b
7 changes: 6 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ rules:
object: assert,
property: deepEqual,
message: Please use assert.deepStrictEqual().
}, {
property: __defineGetter__,
message: __defineGetter__ is deprecated.
}, {
property: __defineSetter__,
message: __defineSetter__ is deprecated.
}]

# Stylistic Issues
Expand Down Expand Up @@ -112,7 +118,6 @@ rules:
align-multiline-assignment: 2
assert-fail-single-argument: 2
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
no-definegetter-definesetter: 2

# Global scoped method and vars
globals:
Expand Down
32 changes: 0 additions & 32 deletions tools/eslint-rules/no-definegetter-definesetter.js
View file
Open in desktop

This file was deleted.