Skip to content

test: remove duplicate required module #9169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
+10 −11
Closed

test: remove duplicate required module #9169

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb1c076
test: remove duplicate required module
Trott Oct 18, 2016
e53bad0
squash: other tweaks
Trott Oct 18, 2016
6ddddb7
squash: assert.ifError()
Trott Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: other tweaks
  • Loading branch information
@Trott
Trott committed Oct 18, 2016
commit e53bad05698353681e54457d8665258a91d34a35
20 changes: 10 additions & 10 deletions test/parallel/test-setproctitle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,27 @@ if (!(common.isFreeBSD || common.isOSX || common.isLinux)) {
return;
}

var assert = require('assert');
var exec = require('child_process').exec;
var path = require('path');
const assert = require('assert');
const exec = require('child_process').exec;
const path = require('path');

// The title shouldn't be too long; libuv's uv_set_process_title() out of
// security considerations no longer overwrites envp, only argv, so the
// maximum title length is possibly quite short.
var title = 'testme';
let title = 'testme';

assert.notEqual(process.title, title);
assert.notStrictEqual(process.title, title);
process.title = title;
assert.equal(process.title, title);
assert.strictEqual(process.title, title);

exec('ps -p ' + process.pid + ' -o args=', function(error, stdout, stderr) {
assert.equal(error, null);
assert.equal(stderr, '');
exec(`ps -p ${process.pid} -o args=`, function callback(error, stdout, stderr) {
assert.strictEqual(error, null);
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: assert.ifError()?

assert.strictEqual(stderr, '');

// freebsd always add ' (procname)' to the process title
if (common.isFreeBSD)
title += ` (${path.basename(process.execPath)})`;

// omitting trailing whitespace and \n
assert.equal(stdout.replace(/\s+$/, ''), title);
assert.strictEqual(stdout.replace(/\s+$/, ''), title);
});