Skip to content

Fix test debug agent #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larissayvette wants to merge 4 commits into from
Closed

Fix test debug agent #9119

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f66d7a
test: checking if error constructor is assert.AssertionError
larissayvette Oct 12, 2016
f5dd294
test: checking if error constructor is assert.AssertionError
larissayvette Oct 14, 2016
ee29c7a
test: checking whether error constructor is assert.AssertionError
larissayvette Oct 15, 2016
92550d1
nits: identations
larissayvette Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: checking whether error constructor is assert.AssertionError
  • Loading branch information
@larissayvette
larissayvette committed Oct 15, 2016
commit ee29c7a65c050e76543a875ef25adfa1d6462e0a
5 changes: 2 additions & 3 deletions test/parallel/test-debug-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ const debug = require('_debug_agent');
assert.throws(
() => { debug.start();},
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Oct 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use consistent spacing around the curly braces.

function(err) {
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Oct 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks off here.

if ((err instanceof assert.AssertionError) && /value/.test(err)) {
return true;
}
return (err instanceof assert.AssertionError &&
err.message === 'Debugger agent running without bindings!');
}
);