Skip to content

Make tests more clear #8999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jennabelle wants to merge 8 commits into from
Closed

Make tests more clear #8999

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af9e4d0
replace ==, !=, some instances of var, and assert.equal()
Sep 25, 2016
f04c78c
change var to const
Oct 10, 2016
3d27c89
change 'var' to 'const' for clarity
Oct 10, 2016
055e479
trying to complete git pull upstream master
jennabelle Oct 10, 2016
95b1fcd
completing merge
jennabelle Oct 11, 2016
be11d1a
Change last `var` to `const`, add `assert.strictEqual()`
Oct 11, 2016
393a059
add semicolon after `assert.strictEqual()`
Oct 11, 2016
e02413c
Refactor for readability and change `var` to `const`
Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change last var to const, add assert.strictEqual() 
Add `assert.strictEqual(err.code, 'ENOENT')` and changed the last `var` to `const` for clarity
  • Loading branch information
Jenna Vuong authored Oct 11, 2016
commit be11d1a33b4d94b68af077136569e76a3edb5ea4
3 changes: 2 additions & 1 deletion test/parallel/test-file-read-noexist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ const assert = require('assert');
const path = require('path');
const fs = require('fs');

var filename = path.join(common.fixturesDir, 'does_not_exist.txt');
const filename = path.join(common.fixturesDir, 'does_not_exist.txt');
fs.readFile(filename, 'latin1', common.mustCall(function(err, content) {
Copy link
Copy Markdown
Member

@Trott Trott Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we add a line after assert.ok(err) like assert.strictEqual(err.code, 'ENOENT') or whatever the right error code is? I assume it will be the same across platform, but correction welcome.

Copy link
Copy Markdown
Contributor Author

@jennabelle jennabelle Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

assert.ok(err);
assert.strictEqual(err.code, 'ENOENT')
}));