Skip to content

lib: update outdated comment #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanujasawant wants to merge 2 commits into from
Closed

lib: update outdated comment #8988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b1d2fe
lib: update outdated comment
tanujasawant Oct 9, 2016
78ab70a
lib: update outdated comment
tanujasawant Oct 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) {
args = execArgv.concat([modulePath], args);

if (!Array.isArray(options.stdio)) {
// Leave stdin open for the IPC channel. stdout and stderr should be the
// same as the parent's if silent isn't set.
// Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Oct 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave "the" in front of "IPC channel".

Copy link
Copy Markdown
Contributor Author

@tanujasawant tanujasawant Oct 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm I have left out the 'the'
@cjihrig

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Oct 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I mean please leave it as it was. In other words, have it say "for the IPC channel."

Copy link
Copy Markdown
Contributor Author

@tanujasawant tanujasawant Oct 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, thanks. It's done =)

// from the parent if silent isn't set.
options.stdio = options.silent ? ['pipe', 'pipe', 'pipe', 'ipc'] :
[0, 1, 2, 'ipc'];
} else if (options.stdio.indexOf('ipc') === -1) {
Expand Down