Skip to content

net: unref timer in parent sockets #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 3 commits into from
Closed

net: unref timer in parent sockets #891

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f471f2
net: unref timer in parent sockets
indutny Feb 19, 2015
416ca34
fix
indutny Feb 19, 2015
7a8d34d
fix
indutny Feb 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@indutny
indutny committed Feb 19, 2015
commit 7a8d34dfc355f87c52d97a3e5b4ec7ab6c4702a7
6 changes: 3 additions & 3 deletions lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,12 @@ function TLSSocket(socket, options) {
readable: false,
writable: false
});
if (socket)
if (socket) {
this._parent = socket;
Copy link
Copy Markdown
Contributor

@yorkie yorkie Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not combine the 2 following lines into one if statement like:

if (socket)
  this._parent = socket,
  this._connecting = socket._connecting;

Copy link
Copy Markdown
Member Author

@indutny indutny Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


// To prevent assertion in afterConnect()
if (socket)
// To prevent assertion in afterConnect()
this._connecting = socket._connecting;
}

this._tlsOptions = options;
this._secureEstablished = false;
Expand Down