Repository navigation
Conversation
This replace all `var` occurrences in test-file-write-stream.js with `const` (where they are not being reassigned) and `let` (where they are being reassigned).
This add strict comparison to the asserts and if statements:
- Replace `assert.equal` with `assert.strictEqual` where:
1. Result of `typeof` being compared to a string literal.
2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
a string constant.
- Replace `==` with `===` where integer values are being compared to
integer literals.
targos
approved these changes
Oct 2, 2016
| for (let i = 0; i < 11; i++) { | ||
| (function(i) { | ||
| file.write('' + i); | ||
| })(i); |
Member
There was a problem hiding this comment.
I think this can be simplified by removing the IIFE
Contributor
Author
There was a problem hiding this comment.
Removed the IIFE, Thanks for pointing it out.
lpinca
reviewed
Oct 2, 2016
| process.on('exit', function() { | ||
| for (var k in callbacks) { | ||
| for (const k in callbacks) { | ||
| assert.equal(0, callbacks[k], k + ' count off by ' + callbacks[k]); |
Member
There was a problem hiding this comment.
Nit: how about using strictEqual and a template literal here?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out. Updated it.
This replace a `assert.equal` with a `assert.strictEqual` which was missed in previous commit.
Member
Member
|
LGTM if CI doesn't reveal any issues with the test. Looping in @thealphanerd in case they have an opinion about the introduction of |
addaleax
approved these changes
Oct 3, 2016
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM, and fwiw I’m perfectly fine with let here.
cjihrig
approved these changes
Oct 3, 2016
Member
|
CI failures are unrelated known flaky tests. Landing. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 5, 2016
Replace all `var` occurrences in test-file-write-stream.js with
`const` (where they are not being reassigned) and `let` (where they are
being reassigned).
Add strict comparison to the asserts and if statements:
- Replace `assert.equal` with `assert.strictEqual` where:
1. Result of `typeof` being compared to a string literal.
2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
a string constant.
- Replace `==` with `===` where integer values are being compared to
integer literals.
Remove unnecessary very IIFE.
Use template literals.
PR-URL: nodejs#8894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 1d4ba1b |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Replace all `var` occurrences in test-file-write-stream.js with
`const` (where they are not being reassigned) and `let` (where they are
being reassigned).
Add strict comparison to the asserts and if statements:
- Replace `assert.equal` with `assert.strictEqual` where:
1. Result of `typeof` being compared to a string literal.
2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
a string constant.
- Replace `==` with `===` where integer values are being compared to
integer literals.
Remove unnecessary very IIFE.
Use template literals.
PR-URL: #8894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Replace all `var` occurrences in test-file-write-stream.js with
`const` (where they are not being reassigned) and `let` (where they are
being reassigned).
Add strict comparison to the asserts and if statements:
- Replace `assert.equal` with `assert.strictEqual` where:
1. Result of `typeof` being compared to a string literal.
2. Result of `fs.readFileSync` with UTF-8 encoding being compared to
a string constant.
- Replace `==` with `===` where integer values are being compared to
integer literals.
Remove unnecessary very IIFE.
Use template literals.
PR-URL: #8894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Some trivial changes to improve the test code in
test/parallel/test-file-write-stream.js.Submitting this as my first contribution as per instructions from NodeTodo.