Skip to content

src: remove unused function declaration#8878

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:src-remove-unused-udp-func
Closed

src: remove unused function declaration#8878
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:src-remove-unused-udp-func

Conversation

@mscdex
Copy link
Copy Markdown
Contributor

@mscdex mscdex commented Oct 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • src
Description of change

Removes an unused function declaration.

CI: https://ci.nodejs.org/job/node-test-pull-request/4346/

EDIT: CI is green except for a flaky test.

@mscdex mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. c++ Issues and PRs that require attention from people who are familiar with C++. labels Oct 1, 2016
Copy link
Copy Markdown
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhinkel
Copy link
Copy Markdown
Member

fhinkel commented Oct 3, 2016

Thanks. Landed in 2893bd2.

@fhinkel fhinkel closed this Oct 3, 2016
fhinkel pushed a commit that referenced this pull request Oct 3, 2016
PR-URL: #8878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mscdex mscdex deleted the src-remove-unused-udp-func branch October 3, 2016 14:36
jasnell pushed a commit that referenced this pull request Oct 6, 2016
PR-URL: #8878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8878
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants