Skip to content

stream: proper instanceof for Writables #8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

stream: proper instanceof for Writables #8834

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
026c95a
stream: proper `instanceof` for `Writable`s
addaleax Sep 28, 2016
a21153d
[squash] fix typo
addaleax Sep 28, 2016
35c92b9
[squash] by → due to
addaleax Sep 28, 2016
297b6fd
[squash] feature-detect `Symbol`
addaleax Sep 29, 2016
de72676
[squash] more comments!
addaleax Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] by → due to
  • Loading branch information
@addaleax
addaleax committed Sep 28, 2016
commit 35c92b9a1aa6253ef68f9586b3a7585b01335d1f
3 changes: 2 additions & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,8 @@ to extending the `stream.Readable` *and* `stream.Writable` classes).

*Note*: The `stream.Duplex` class prototypically inherits from `stream.Readable`
and parasitically from `stream.Writable`, but `instanceof` will work properly
for both base classes by overriding [`Symbol.hasInstance`][].
for both base classes due to overriding [`Symbol.hasInstance`][]
on `stream.Writable`.

Custom Duplex streams *must* call the `new stream.Duplex([options])`
constructor and implement *both* the `readable._read()` and
Expand Down