Skip to content

tls: hard deprecate tls.createSecurePair #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yorkie wants to merge 1 commit into from
Closed

tls: hard deprecate tls.createSecurePair #8783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tls: deprecate tls.createSecurePair in runtime
  • Loading branch information
@yorkie
yorkie committed Jan 6, 2017
commit 36e31336aab2952381bf6007fd33396e0d138cd1
4 changes: 3 additions & 1 deletion lib/tls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,6 @@ exports.TLSSocket = require('_tls_wrap').TLSSocket;
exports.Server = require('_tls_wrap').Server;
exports.createServer = require('_tls_wrap').createServer;
exports.connect = require('_tls_wrap').connect;
exports.createSecurePair = require('_tls_legacy').createSecurePair;
exports.createSecurePair = internalUtil.deprecate(function() {
return require('_tls_legacy').createSecurePair.apply(null, arguments);
}, 'tls.createSecurePair is deprecated. Use tls.TLSSocket instead.');
11 changes: 11 additions & 0 deletions test/parallel/test-tls-deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';
const common = require('../common');
const tls = require('tls');

common.expectWarning('DeprecationWarning', [
'tls.createSecurePair is deprecated. Use tls.TLSSocket instead.'
]);

try {
tls.createSecurePair();
} catch (err) {}