Skip to content

test: remove FIXME pummel/test-tls-securepair-client #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ALJCepeda wants to merge 1 commit into from
Closed

test: remove FIXME pummel/test-tls-securepair-client #8757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove FIXME pummel/test-tls-securepair-client 
Reverts: 85827bd
Refs: #4640
Using `common.PORT` no longer causes other tests to fail
  • Loading branch information
@ALJCepeda
ALJCepeda committed Sep 24, 2016
commit c6ed3e6e44b5c24b4cc833c836a5dfbb2ba4dcaf
10 changes: 2 additions & 8 deletions test/pummel/test-tls-securepair-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,14 @@ function test2() {
}

function test(keyfn, certfn, check, next) {
// FIXME: Avoid the common PORT as this test currently hits a C-level
// assertion error with node_g. The program aborts without HUPing
// the openssl s_server thus causing many tests to fail with
// EADDRINUSE.
var PORT = common.PORT + 5;

keyfn = join(common.fixturesDir, keyfn);
var key = fs.readFileSync(keyfn).toString();

certfn = join(common.fixturesDir, certfn);
var cert = fs.readFileSync(certfn).toString();

var server = spawn(common.opensslCli, ['s_server',
'-accept', PORT,
'-accept', common.PORT,
'-cert', certfn,
'-key', keyfn]);
server.stdout.pipe(process.stdout);
Expand Down Expand Up @@ -121,7 +115,7 @@ function test(keyfn, certfn, check, next) {
pair.encrypted.pipe(s);
s.pipe(pair.encrypted);

s.connect(PORT);
s.connect(common.PORT);

s.on('connect', function() {
console.log('client connected');
Expand Down