Skip to content

Removes FIXME #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ALJCepeda wants to merge 4 commits into from
Closed

Removes FIXME #8689

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b42021
Removes FIXME
ALJCepeda Sep 21, 2016
d306cf0
Changes file permission to 644
ALJCepeda Sep 21, 2016
ecce505
Removes FIXME
ALJCepeda Sep 21, 2016
9912570
Changes file permission to 644
ALJCepeda Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removes FIXME 
It's necessary to close the socket otherwise the test will hang
  • Loading branch information
@ALJCepeda
ALJCepeda committed Sep 22, 2016
commit 1b420216b37cab0cd28cfeb1c74721a0374373d6
2 changes: 1 addition & 1 deletion test/parallel/test-dgram-oob-buffer.js
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ socket.send(buf, 3, 1, common.PORT, '127.0.0.1', ok);
// Since length of zero means nothing, don't error despite OOB.
socket.send(buf, 4, 0, common.PORT, '127.0.0.1', ok);

socket.close(); // FIXME should not be necessary
socket.close();