Skip to content

test: cleanup stream tests #8668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
italoacasas wants to merge 8 commits into from
Closed

test: cleanup stream tests #8668

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e58ceb3
cleanup test-stream-big-packet.js
Sep 20, 2016
5daccd2
cleanup test-stream-big-push.js
Sep 20, 2016
076f984
cleanup test-stream-duplex.js
Sep 20, 2016
abe2a91
cleanup test-stream-end-paused.js
Sep 20, 2016
995f48a
cleanup test-stream-ispaused.js
Sep 20, 2016
8862e13
cleanup test-stream-pipe-after-end.js
Sep 20, 2016
832d9ba
cleanup test-stream-pipe-cleanup.js
Sep 20, 2016
837d02f
fixing extra space
Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup test-stream-pipe-after-end.js
  • Loading branch information
Italo A. Casas committed Sep 20, 2016
commit 8862e13b36b4b21d2a6a344389bda83d53714a7e
21 changes: 11 additions & 10 deletions test/parallel/test-stream-pipe-after-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
'use strict';

require('../common');
var assert = require('assert');

var Readable = require('_stream_readable');
var Writable = require('_stream_writable');
var util = require('util');
const assert = require('assert');
const Readable = require('_stream_readable');
const Writable = require('_stream_writable');
const util = require('util');

util.inherits(TestReadable, Readable);
function TestReadable(opt) {
Expand Down Expand Up @@ -35,11 +36,11 @@ TestWritable.prototype._write = function(chunk, encoding, cb) {
};

// this one should not emit 'end' until we read() from it later.
var ender = new TestReadable();
var enderEnded = false;
const ender = new TestReadable();
let enderEnded = false;

// what happens when you pipe() a Readable that's already ended?
var piper = new TestReadable();
const piper = new TestReadable();
// pushes EOF null, and length=0, so this will trigger 'end'
piper.read();

Expand All @@ -48,11 +49,11 @@ setTimeout(function() {
enderEnded = true;
});
assert(!enderEnded);
var c = ender.read();
const c = ender.read();
assert.equal(c, null);

var w = new TestWritable();
var writableFinished = false;
const w = new TestWritable();
let writableFinished = false;
w.on('finish', function() {
writableFinished = true;
});
Expand Down