Skip to content

dns: tweak regex for IPv6 addresses #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpinca wants to merge 1 commit into from
Closed

dns: tweak regex for IPv6 addresses #8665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
dns: tweak regex for IPv6 addresses 
The regex used in `dns.setServers()` to match IPv6 addresses in square
brackets uses a capturing group for the port but this info is not
needed.

This commit replaces the capturing group with a non capturing one.
  • Loading branch information
@lpinca
lpinca committed Sep 20, 2016
commit 4c463d2594d777be4cc3b9ab4d879491261dbd16
2 changes: 1 addition & 1 deletion lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ exports.setServers = function(servers) {
if (ipVersion !== 0)
return [ipVersion, serv];

const match = serv.match(/\[(.*)\](:\d+)?/);
const match = serv.match(/\[(.*)\](?::\d+)?/);
// we have an IPv6 in brackets
if (match) {
ipVersion = isIP(match[1]);
Expand Down