Skip to content

Make it build using openssl 1.1.0 #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kroeckx wants to merge 1 commit into from
Closed

Make it build using openssl 1.1.0 #8491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make it build using openssl 1.1.0
  • Loading branch information
@kroeckx
kroeckx committed Sep 11, 2016
commit 62cc7b80c0840528e6936bd72e3d370e24f8d99f
1 change: 0 additions & 1 deletion lib/_tls_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ exports.createSecureContext = function createSecureContext(options, context) {
// Do not keep read/write buffers in free list
if (options.singleUse) {
c.singleUse = true;
c.context.setFreeListLength(0);
}
Copy link
Copy Markdown
Member

@indutny indutny Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have implications on a memory footprint of the tls.connect(). Since we use SSL_MODE_RELEASE_BUFFERS, the released buffers for such one-time contexts will be kept until the Garbage Collection.

I wonder if there is some way to turn off the freelist feature in OpenSSL 1.1.0?

Copy link
Copy Markdown
Author

@kroeckx kroeckx Sep 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL_MODE_RELEASE_BUFFERS is still supported


return c;
Expand Down
Loading