Skip to content

test: favor === over in == in http test #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jun-oka wants to merge 4 commits into from
Closed

test: favor === over in == in http test #8471

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa4cc28
test: favor ’===’ over in ’==’ in http test
jun-oka Sep 9, 2016
9f3bf42
test: favor ’assert.strictEqual’ over in ’assert.equal’ in http test
jun-oka Sep 9, 2016
d52d5e1
test: favor ’const’ over in ’var’ in http test
jun-oka Sep 9, 2016
b05c4e8
test: favor `const` over in `var` for require in http test
jun-oka Sep 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: favor ’assert.strictEqual’ over in ’assert.equal’ in http test
  • Loading branch information
@jun-oka
jun-oka committed Sep 12, 2016
commit 9f3bf4214ec8046bfc1e7f7835e01c0b4c0cfc97
29 changes: 14 additions & 15 deletions test/parallel/test-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@ var body1 = '';

var server = http.Server(function(req, res) {
Copy link
Copy Markdown
Member

@Trott Trott Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This var and some (but not all) of the others can be changed to const.

if (responses_sent === 0) {
assert.equal('GET', req.method);
assert.equal('/hello', url.parse(req.url).pathname);
assert.strictEqual('GET', req.method);
assert.strictEqual('/hello', url.parse(req.url).pathname);

console.dir(req.headers);
assert.equal(true, 'accept' in req.headers);
assert.equal('*/*', req.headers['accept']);
assert.strictEqual(true, 'accept' in req.headers);
assert.strictEqual('*/*', req.headers['accept']);

assert.equal(true, 'foo' in req.headers);
assert.equal('bar', req.headers['foo']);
assert.strictEqual(true, 'foo' in req.headers);
assert.strictEqual('bar', req.headers['foo']);
}

if (responses_sent === 1) {
assert.equal('POST', req.method);
assert.equal('/world', url.parse(req.url).pathname);
assert.strictEqual('POST', req.method);
assert.strictEqual('/world', url.parse(req.url).pathname);
this.close();
}

Expand All @@ -48,7 +48,7 @@ server.on('listening', function() {
headers: {'Accept': '*/*', 'Foo': 'bar'},
agent: agent
}, function(res) {
assert.equal(200, res.statusCode);
assert.strictEqual(200, res.statusCode);
responses_recvd += 1;
res.setEncoding('utf8');
res.on('data', function(chunk) { body0 += chunk; });
Expand All @@ -62,7 +62,7 @@ server.on('listening', function() {
path: '/world',
agent: agent
}, function(res) {
assert.equal(200, res.statusCode);
assert.strictEqual(200, res.statusCode);
responses_recvd += 1;
res.setEncoding('utf8');
res.on('data', function(chunk) { body1 += chunk; });
Expand All @@ -74,12 +74,11 @@ server.on('listening', function() {

process.on('exit', function() {
console.error('responses_recvd: ' + responses_recvd);
assert.equal(2, responses_recvd);
assert.strictEqual(2, responses_recvd);

console.error('responses_sent: ' + responses_sent);
assert.equal(2, responses_sent);
assert.strictEqual(2, responses_sent);

assert.equal('The path was /hello', body0);
assert.equal('The path was /world', body1);
assert.strictEqual('The path was /hello', body0);
assert.strictEqual('The path was /world', body1);
});