Skip to content

v4.x backport: test,doc: clarify buf.indexOf(num) input range #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 54 commits into from
Closed

v4.x backport: test,doc: clarify buf.indexOf(num) input range #8462

Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
cd55b79
build: add --enable-d8 configure option
bnoordhuis Jul 5, 2016
9308205
test: add --repeat option to tools/test.py
mhdawson May 11, 2016
a0a1de1
build: add node_module_version to config.gypi
saper Jul 20, 2016
3ecd06d
doc: improve server.listen() random port
phillipj Aug 8, 2016
4bfb247
test: exclude tests for AIX
mhdawson Aug 11, 2016
bff9ec8
doc: grammar fixes to event loop guide
ryanmurakami Jun 29, 2016
deec06b
net: export isIPv4, isIPv6 directly from cares
thefourtheye Jun 29, 2016
7e60292
util: inspect boxed symbols like other primitives
addaleax Jul 9, 2016
ef977f6
deps: `MASM.UseSafeExceptionHandlers` for OpenSSL
indutny Jun 26, 2016
09099ab
deps: no /safeseh for ml64.exe
indutny Jul 16, 2016
7151cff
doc: add `added:` info for dgram.*Membership()
Trott May 16, 2016
1c921cc
lib: implement consistent brace style
Trott Jul 9, 2016
b52571c
test: implement consistent braces
Trott Jul 9, 2016
9bddd79
tools: enforce JS brace style with linting
Trott Jul 9, 2016
bceac33
net: make holding the buffer in memory more robust
addaleax Aug 24, 2016
efc77ec
src: use RAII for mutexes and condition variables
bnoordhuis Jun 17, 2016
6123520
tools: increase lint coverage
Trott Jul 10, 2016
3b97b84
doc: add POST_STATUS_TO_PR info to onboarding doc
Trott Aug 10, 2016
d7618e7
doc: minor updates to onboarding doc
Trott Aug 10, 2016
34efb77
doc: delete non-existing zlib constants
fhinkel Jul 2, 2016
9650059
doc: fix util.deprecate() example
evanlucas Jul 12, 2016
2fda453
doc: update CTC governance information
Trott Jul 13, 2016
04ba9eb
doc: update readme with andrasq as a collaborator
Jul 19, 2016
8437444
doc: clarify that the node.js irc channel is not under tsc oversight
jasnell Jul 20, 2016
681890c
doc: add princejwesley to collaborators
princejwesley Jul 26, 2016
ba6982f
doc: remove platform assumption from CONTRIBUTING
BethGriggs Jul 18, 2016
9d0f005
doc: add information about CTC quorum rules
Trott Jul 20, 2016
13403e4
meta: provide example activities
Trott Jul 15, 2016
b8ff67c
doc: add CTC meeting minutes 2016-07-27
williamkapke Jul 27, 2016
5ad0652
meta: include a minimal CTC removal policy
Trott Jul 13, 2016
fa66140
doc: add CTC meeting minutes 2016-06-29
joshgav Jul 6, 2016
1db02af
doc: add CTC meeting minutes 2016-07-06
joshgav Jul 6, 2016
9296373
doc: add @addaleax to the CTC
addaleax Aug 3, 2016
2d9cd3b
doc: piscisaureus has stepped-down from the CTC
jasnell Aug 3, 2016
602b8a0
doctool: improve the title of pages in doc
yorkie Aug 1, 2016
bf33d2f
doc: use `git-secure-tag` for release tags
indutny Jul 23, 2016
52be1d3
meta: clarify process for breaking changes
Trott Aug 3, 2016
02293b1
doc: use consistent markdown in README
Trott Aug 3, 2016
6a44d33
doc: add CTC meeting minutes 2016-07-20
joshgav Aug 3, 2016
763e51c
doc: add CTC meeting minutes 2016-07-13
joshgav Aug 3, 2016
857267e
tools: add .vscode folder to .gitignore
joshgav Aug 3, 2016
320db05
doc: clarify "Reviewed-By" iff "LGTM"
bengl Jun 6, 2016
65abbfe
doc: clarify collaborators & ctc members relationships
yorkie Aug 6, 2016
d1360f5
tools: add remark-lint configuration in .remarkrc
ChALkeR Jul 14, 2016
dfde977
doc: fix a markdown error in CTC meeting minutes
ChALkeR Aug 5, 2016
0a26433
doc: add CTC meeting minutes 2016-08-03
joshgav Aug 4, 2016
f9ba4b5
doc: Add fhinkel to collaborators
fhinkel Aug 10, 2016
3ceabd6
doc: move orangemocha to collaborators list
Trott Aug 11, 2016
4bfb50d
doc: update Reviewing section of onboarding doc
Trott Aug 12, 2016
24c3d25
doc: add @joshgav to collaborators
joshgav Aug 17, 2016
5f38ce0
doc: update release announce instruction to tweet
hackygolucky Aug 16, 2016
5867e09
doc: remove outdated LTS info from ROADMAP.md
Trott Aug 18, 2016
8122aa0
doc: remove "feature branch" jargon
Trott Aug 20, 2016
17e96db
test,doc: clarify `buf.indexOf(num)` input range
addaleax Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix a markdown error in CTC meeting minutes 
This fixes a markdown formatting error in 2016-07-13 CTC meeting
minutes, __proto__ was rendered incorrectly.

This was found by remark-lint.

PR-URL: #7729
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
  • Loading branch information
@ChALkeR
ChALkeR authored and Myles Borins committed Sep 9, 2016
commit dfde977ca16aa6b00d15e0ac69ee7459cda630be
2 changes: 1 addition & 1 deletion doc/ctc-meetings/2016-07-13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ ELOOP issue has been resolved. Windows problem being addressed in another PR. Ma

### http: don't inherit from Object.prototype [#6102](https://github.com/nodejs/node/pull/6102)

@mscdex: Prevent clash of header names with properties inherited from Object (e.g., __proto__). An object with a null prototype is already being used for the same purpose in `querystring.parse` since v6 release.
@mscdex: Prevent clash of header names with properties inherited from Object (e.g., `__proto__`). An object with a null prototype is already being used for the same purpose in `querystring.parse` since v6 release.

@mscdex: Some have suggested cherry-picking some methods from Object such as `toString`:

Expand Down