Skip to content

doc: update landing pr info in onboarding doc #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

doc: update landing pr info in onboarding doc #8344

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b831bea
doc: update landing pr info in onboarding doc
Trott Aug 30, 2016
8a98226
squash: address nits
Trott Aug 31, 2016
2f5bfe3
squash: rewording
Trott Aug 31, 2016
95354ba
squash: add trivial example
Trott Aug 31, 2016
ee1eb7e
squash: more trivial info
Trott Aug 31, 2016
2bd288c
squash: addons
Trott Aug 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: addons
  • Loading branch information
@Trott
Trott committed Aug 31, 2016
commit 2bd288cf38f0f76414044d7ce03769eb6f1b1db0
2 changes: 1 addition & 1 deletion doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ onboarding session.
* An example of a trivial change would be correcting the misspelling of a single word in a documentation file. This sort of change still needs to receive at least one `LGTM` but it does not need to wait 48 hours before landing.

* **Run the PR through CI before merging!**
* An exception can be made for documentation-only PRs.
* An exception can be made for documentation-only PRs as long as it does not include the `addons.md` documentation file. (Example code from that document is extracted and built as part of the tests!)

* What if something goes wrong?
* Ping a CTC member.
Expand Down