Skip to content

WIP: test: force garbage collection on crypto timing test #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 7 commits into from
Closed

WIP: test: force garbage collection on crypto timing test #8203

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b487bfb
test: force garbage collection on crypto timing test
Trott Aug 21, 2016
347e60d
squash: gc every time
Trott Aug 21, 2016
ac7c143
squash: 10K -> 1K
Trott Aug 21, 2016
c672a47
squash: flip
Trott Aug 21, 2016
26a3080
squash: logging
Trott Aug 21, 2016
fb8c326
squash: two separate functions for benchmarks
not-an-aardvark Aug 22, 2016
4f562ee
squash: replace timingSafeEqual with incorrect timing-safe function
not-an-aardvark Aug 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: gc every time
  • Loading branch information
@Trott
Trott committed Aug 21, 2016
commit 347e60dfefe7258782438a0a9989f7a0dc138571
5 changes: 2 additions & 3 deletions test/sequential/test-crypto-timing-safe-equal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ assert.throws(function() {
}, 'should throw if the second argument is not a buffer');

function runBenchmark(compareFunc, bufferA, bufferB, expectedResult) {
// Make sure garbage collection does not interfere with timing
global.gc();
const startTime = process.hrtime();
const result = compareFunc(bufferA, bufferB);
const endTime = process.hrtime(startTime);
Expand Down Expand Up @@ -129,8 +131,6 @@ runBenchmark(crypto.timingSafeEqual, Buffer.from('A'), Buffer.from('A'), true);
// significantly affect the threshold.
const T_THRESHOLD = 3.291;

// Make sure garbage collection does not interfere with timing
global.gc();
const t = getTValue(crypto.timingSafeEqual);
assert(
Math.abs(t) < T_THRESHOLD,
Expand All @@ -141,7 +141,6 @@ assert(
// same benchmarks again, this time with an unsafe comparison function. In this
// case the t-value should be above the threshold.
const unsafeCompare = (bufA, bufB) => bufA.equals(bufB);
global.gc();
const t2 = getTValue(unsafeCompare);
assert(
Math.abs(t2) > T_THRESHOLD,
Expand Down