Skip to content

stream: move legacy to lib/internal dir #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yorkie wants to merge 5 commits into from
Closed

stream: move legacy to lib/internal dir #8197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
625bf71
stream: move legacy to sep file
yorkie Aug 9, 2016
876c3ad
stream: move legacy to lib/internal dir
yorkie Jan 7, 2017
1005ccb
fix nit
yorkie Jan 17, 2017
ece3060
fix nits
yorkie Jan 17, 2017
4e14f31
fix nit
yorkie Jan 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix nits
  • Loading branch information
@yorkie
yorkie committed Jan 17, 2017
commit ece3060015c6c3803f246f09ee5d1a55809ab89d
2 changes: 0 additions & 2 deletions lib/internal/streams/legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
'use strict';

const util = require('util');
const EE = require('events');

module.exports = function(Stream) {
// old-style streams. Note that the pipe method (the only relevant
// part of this class) is overridden in the Readable class.

util.inherits(Stream, EE);
Stream.prototype.pipe = function(dest, options) {
var source = this;

Expand Down
11 changes: 11 additions & 0 deletions lib/internal/streams/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';

const EE = require('events');
const util = require('util');

function Stream() {
EE.call(this);
}
util.inherits(Stream, EE);

exports.Stream = Stream;
Copy link
Copy Markdown
Contributor

@mscdex mscdex Jan 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file should be merged with lib/internal/streams/legacy.js

The legacy.js file should then just module.exports = Stream; and lib/stream.js should just require() that.

Copy link
Copy Markdown
Member

@mcollina mcollina Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this, I think we agree.

6 changes: 1 addition & 5 deletions lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
'use strict';

const util = require('util');

function Stream() {
EE.call(this);
}
var Stream = require('internal/streams/stream').Stream;

// wrap the old-style stream
require('internal/streams/legacy')(Stream);
Copy link
Copy Markdown
Member

@mcollina mcollina Jan 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear to me. Basically the definition of Stream is divided into two files, whicn is not easy to understand in my opinion. If we also move the definition of Stream, I think internal/streams/stream should also include the 'legacy' bits.

How about we move all _stream prefixed files into internal/streams? That might be a better solution overall.
cc @nodejs/streams.

Copy link
Copy Markdown
Contributor

@mscdex mscdex Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You couldn't just move those files because that would break someone trying to require() them? Unless you mean leave behind similarly-named files that simple re-export?

Also, I think the point of this PR was to separate the actual old Stream implementation from the other things, like the re-exporting of the various stream types.

Copy link
Copy Markdown
Member

@mcollina mcollina Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but then why split the definition of it in one file, and the legacy part in another?
Either we just move the legacy bits, we move the full definition, or we move all the streams parts.

I'm 👎 in having both internal/streams/stream and internal/streams/legacy, if we are not moving along readable, writable, etc.

Expand Down