Skip to content

test: add test for invalid cert string #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: add test for invalid cert string #8179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60b6bed
test: add test for invalid cert string
Trott Aug 19, 2016
ea84c0d
squash: scope tests
Trott Aug 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add test for invalid cert string 
`tls.parseCertString()` should return an empty object if passed an
invalid cert string. This behavior is not currently tested. Add minimal
test.
  • Loading branch information
@Trott
Trott committed Aug 19, 2016
commit 60b6bed891d76146367276b073279c588dad5992
4 changes: 4 additions & 0 deletions test/parallel/test-tls-parse-cert-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ assert.deepStrictEqual(doublesOut, {
OU: [ 'Domain Control Validated', 'PositiveSSL Wildcard' ],
CN: '*.nodejs.org'
});

const invalid = 'fhqwhgads';
const invalidOut = tls.parseCertString(invalid);
assert.deepStrictEqual(invalidOut, {});
Copy link
Copy Markdown
Contributor

@yorkie yorkie Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add brackets to scope the above statements?