Skip to content

dns: lookupService() callback must be a function #8170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 2 commits into from
Closed

dns: lookupService() callback must be a function #8170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ba118
dns: lookupService() callback must be a function
cjihrig Aug 18, 2016
2bebeb1
dns: remove makeAsync() function check
cjihrig Aug 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dns: remove makeAsync() function check 
makeAsync() is an internal method in the dns module. All of the
functions that call makeAsync() have already validated that the
callback is a function. This commit removes a redundant typeof
function check.
  • Loading branch information
@cjihrig
cjihrig committed Aug 18, 2016
commit 2bebeb1bd5c2bf95dd9cd9712fd684719487ab91
3 changes: 0 additions & 3 deletions lib/dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ function errnoException(err, syscall, hostname) {
// callback.immediately = true;
// }
function makeAsync(callback) {
if (typeof callback !== 'function') {
return callback;
}
return function asyncCallback() {
if (asyncCallback.immediately) {
// The API already returned, we can invoke the callback immediately.
Expand Down