Skip to content

fs: restore javascript realpath implementation #7899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 7 commits into from
Closed

fs: restore javascript realpath implementation #7899

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad79524
fs: restore JS implementation of realpath
bzoz Jul 26, 2016
32cc5d2
fixup: reimplement new realpath API
bzoz Jul 26, 2016
f806237
test,bench: add tests/bench for fs.realpath() fix
trevnorris Jul 14, 2016
5a1a790
fixup: remove test_deep_symlink_eloop test
bzoz Jul 29, 2016
cad4d82
fixup: handle buffer parameters
bzoz Aug 9, 2016
94b4214
Add note about buffer parameters to documentation
bzoz Aug 10, 2016
1ed6028
fixup: spelling
bzoz Aug 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add note about buffer parameters to documentation
  • Loading branch information
@bzoz
bzoz committed Aug 10, 2016
commit 94b4214eb8fed2b6538e0ee3da567921bcd65f41
8 changes: 6 additions & 2 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,8 @@ added: v0.1.31
Asynchronous realpath(3). The `callback` gets two arguments `(err,
resolvedPath)`. May use `process.cwd` to resolve relative paths.

Only paths that can be converted to UTF8 strings are supported.

The optional `options` argument can be a string specifying an encoding, or an
object with an `encoding` property specifying the character encoding to use for
the path passed to the callback. If the `encoding` is set to `'buffer'`,
Expand All @@ -1229,10 +1231,12 @@ added: v0.1.31

Synchronous realpath(3). Returns the resolved path.

Only paths that can be converted to UTF8 strings are supported.

The optional `options` argument can be a string specifying an encoding, or an
object with an `encoding` property specifying the character encoding to use for
the path passed to the callback. If the `encoding` is set to `'buffer'`,
the path returned will be passed as a `Buffer` object.
the returned value. If the `encoding` is set to `'buffer'`, the path returned
will be passed as a `Buffer` object.

## fs.rename(oldPath, newPath, callback)
<!-- YAML
Expand Down