Skip to content

test: fix flaky test-tls-wrap-timeout #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

test: fix flaky test-tls-wrap-timeout #7857

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b17997
test: fix flaky test-tls-wrap-timeout
Trott Jul 23, 2016
6185e4b
squash: add _idleStart check
Trott Jul 26, 2016
84ed1ea
squash: moar ticks, later asserts
Trott Jul 27, 2016
58d3fbf
squash: additional assertion
Trott Jul 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: moar ticks, later asserts
  • Loading branch information
@Trott
Trott committed Jul 31, 2016
commit 84ed1ea55748c88c1331e2ed39de5fbf46048947
11 changes: 6 additions & 5 deletions test/parallel/test-tls-wrap-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ const options = {

const server = tls.createServer(options, common.mustCall((c) => {
setImmediate(() => {
c.write('hello');
setImmediate(() => {
c.destroy();
server.close();
assert(lastIdleStart < socket._idleStart);
c.write('hello', () => {
setImmediate(() => {
c.destroy();
server.close();
});
});
});
}));
Expand All @@ -49,4 +49,5 @@ server.listen(0, () => {

process.on('exit', () => {
assert.strictEqual(socket._idleTimeout, -1);
assert(lastIdleStart < socket._idleStart);
});