Skip to content

tools: enforce loading required modules first #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

tools: enforce loading required modules first #7830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc591e9
tools: enforce loading required modules first
Trott Jul 21, 2016
106b38a
squash: micro-optimize
Trott Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: enforce loading required modules first 
Refs: #7786
  • Loading branch information
@Trott
Trott committed Jul 22, 2016
commit bc591e9456e2264c43754930f8a2b769aab30733
18 changes: 8 additions & 10 deletions tools/eslint-rules/required-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* @fileoverview Require usage of specified node modules.
* @fileoverview Require usage of specified node modules before any other
* modules are loaded.
* @author Rich Trott
*/
'use strict';
Expand Down Expand Up @@ -63,11 +64,16 @@ module.exports = function(context) {

return {
'CallExpression': function(node) {
if (isRequireCall(node)) {
if (isRequireCall(node) && foundModules.length < requiredModules.length) {
var requiredModuleName = getRequiredModuleName(node);

if (requiredModuleName) {
foundModules.push(requiredModuleName);
} else {
context.report(
node,
'Module loaded before all required modules loaded.'
);
}
}
},
Expand All @@ -89,11 +95,3 @@ module.exports = function(context) {
}
};
};

module.exports.schema = {
'type': 'array',
'additionalItems': {
'type': 'string'
},
'uniqueItems': true
};