Skip to content

src: don't include a null character in the WriteConsoleW call #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seishun wants to merge 3 commits into from
Closed

src: don't include a null character in the WriteConsoleW call #7764

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc5e74
src: don't include a null character in the WriteConsoleW call
seishun Jul 16, 2016
d325fbe
different approach
seishun Jul 17, 2016
8e246c5
add a check
seishun Aug 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
different approach
  • Loading branch information
@seishun
seishun committed Aug 21, 2016
commit d325fbe886f332c9a706228ce96a87ef9788d95b
6 changes: 4 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,13 @@ static void PrintErrorString(const char* format, ...) {
vsprintf(out.data(), format, ap);

// Get required wide buffer size
n = MultiByteToWideChar(CP_UTF8, 0, out.data(), n, nullptr, 0);
n = MultiByteToWideChar(CP_UTF8, 0, out.data(), -1, nullptr, 0);

std::vector<wchar_t> wbuf(n);
MultiByteToWideChar(CP_UTF8, 0, out.data(), -1, wbuf.data(), n);
WriteConsoleW(stderr_handle, wbuf.data(), n, nullptr, nullptr);

// Don't include the null character in the output
WriteConsoleW(stderr_handle, wbuf.data(), n - 1, nullptr, nullptr);
#else
vfprintf(stderr, format, ap);
#endif
Expand Down