Skip to content

test: ensure stream preprocessing order #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 11 commits into from
Closed

test: ensure stream preprocessing order #7741

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df751d9
test: ensure stream preprocessing order
vsemozhetbyt Jul 14, 2016
50fd2c8
Delete stream-preprocess.js
vsemozhetbyt Jul 15, 2016
06f89b8
Delete file-to-read-without-bom.txt
vsemozhetbyt Jul 15, 2016
d74e6df
Delete file-to-read-with-bom.txt
vsemozhetbyt Jul 15, 2016
62379f3
Add .txt files to fixtures
vsemozhetbyt Jul 15, 2016
099a111
Add test-stream-preprocess.js to parallel
vsemozhetbyt Jul 15, 2016
a05ea83
Fix test-stream-preprocess.js style issues
vsemozhetbyt Jul 15, 2016
473da05
Fix another test-stream-preprocess.js style issue
vsemozhetbyt Jul 15, 2016
376ea47
Use common.fixturesDir, add some more assertions
vsemozhetbyt Jul 15, 2016
f41dca2
Remove redundant assertions
vsemozhetbyt Jul 15, 2016
6d7e25f
Fix comments style and variable name
vsemozhetbyt Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comments style and variable name
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt authored Jul 19, 2016
commit 6d7e25fbd43056283ca54449dd93b71bed3fffad
16 changes: 8 additions & 8 deletions test/parallel/test-stream-preprocess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,24 @@ const rl = require('readline');

const BOM = '\uFEFF';

// get the data by a non-stream way to compare with the streamed data
// Get the data using a non-stream way to compare with the streamed data.
const modelData = fs.readFileSync(
path.join(common.fixturesDir, 'file-to-read-without-bom.txt'), 'utf8'
);
const modelDataFirstCharacter = modelData[0];

// detect the number of forthcoming 'line' events for mustCall() 'expected' arg
const linesNumber = modelData.match(/\n/g).length;
// Detect the number of forthcoming 'line' events for mustCall() 'expected' arg.
const lineCount = modelData.match(/\n/g).length;

// ensure both without-bom and with-bom test files are textwise equal
// Ensure both without-bom and with-bom test files are textwise equal.
assert.strictEqual(
fs.readFileSync(
path.join(common.fixturesDir, 'file-to-read-with-bom.txt'), 'utf8'
),
`${BOM}${modelData}`
);

// an unjustified BOM stripping with a non-BOM character unshifted to a stream
// An unjustified BOM stripping with a non-BOM character unshifted to a stream.
const inputWithoutBOM = fs.createReadStream(
path.join(common.fixturesDir, 'file-to-read-without-bom.txt'), 'utf8'
);
Expand All @@ -42,12 +42,12 @@ inputWithoutBOM.once('readable', common.mustCall(() => {
input: inputWithoutBOM,
}).on('line', common.mustCall((line) => {
streamedData += `${line}\n`;
}, linesNumber)).on('close', common.mustCall(() => {
}, lineCount)).on('close', common.mustCall(() => {
assert.strictEqual(streamedData, modelData);
}));
}));

// a justified BOM stripping
// A justified BOM stripping.
const inputWithBOM = fs.createReadStream(
path.join(common.fixturesDir, 'file-to-read-with-bom.txt'), 'utf8'
);
Expand All @@ -61,7 +61,7 @@ inputWithBOM.once('readable', common.mustCall(() => {
input: inputWithBOM,
}).on('line', common.mustCall((line) => {
streamedData += `${line}\n`;
}, linesNumber)).on('close', common.mustCall(() => {
}, lineCount)).on('close', common.mustCall(() => {
assert.strictEqual(streamedData, modelData);
}));
}));