Skip to content

Bring the doctool up to date on v4.x #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MylesBorins merged 20 commits into from
Jul 12, 2016
Merged

Bring the doctool up to date on v4.x #7668

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b064daa
tools: add mock-y js-yaml dependency to doctool
addaleax May 1, 2016
f6b5db6
tools: parse documentation metadata
tflanagan Nov 14, 2015
de131cb
test,tools: test yaml parsing of doctool
addaleax Apr 30, 2016
cab73be
tools: allow multiple added: version entries
addaleax Apr 30, 2016
fcb2735
tools: update marked dependency
firedfox Apr 25, 2016
642f214
tools: lint for object literal spacing
Trott May 5, 2016
bad9df9
[SQUASH] extra v4.x-only fixes for object literal spacing spacing
addaleax Jul 12, 2016
5b34603
test: build addons with V8_DEPRECATION_WARNINGS=1
bnoordhuis May 9, 2016
9929173
doc: fix deprecation warnings in addon examples
bnoordhuis May 9, 2016
6faecba
build,test: fix build-addons dependency chain
bnoordhuis May 9, 2016
4e8e59b
tools: fix tools/doc/addon-verify.js regression
addaleax May 9, 2016
ace5efe
build: add Make `doc-only` target
jmm Nov 18, 2015
9c4838f
tools: fix regression in doctool
May 10, 2016
7181973
test: refactor doctool tests
Trott May 12, 2016
d5cb704
tools: restore change of signatures to opts hashes
jmm May 10, 2016
1b0128a
tools: make sure doctool anchors respect includes
addaleax May 23, 2016
5c93e0a
tools,doc: add example usage for REPLACEME tag
addaleax May 19, 2016
2f7685a
build: add REPLACEME tag for version info in docs
bnoordhuis May 13, 2016
383a57a
test: skip doctool tests when js-yaml is missing
addaleax Jun 8, 2016
76c7918
doc: make doc-only -> fallback to user binary
eljefedelrodeodeljefe May 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix deprecation warnings in addon examples 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@bnoordhuis @addaleax
bnoordhuis authored and addaleax committed Jul 12, 2016
commit 9929173adcd00b926fc81e13ae8f21bed7781782
26 changes: 21 additions & 5 deletions doc/api/addons.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@ prototype:

namespace demo {

using v8::Context;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
Expand Down Expand Up @@ -597,8 +598,11 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
// Invoked as plain function `MyObject(...)`, turn into construct call.
const int argc = 1;
Local<Value> argv[argc] = { args[0] };
Local<Context> context = isolate->GetCurrentContext();
Local<Function> cons = Local<Function>::New(isolate, constructor);
args.GetReturnValue().Set(cons->NewInstance(argc, argv));
Local<Object> result =
cons->NewInstance(context, argc, argv).ToLocalChecked();
args.GetReturnValue().Set(result);
}
}

Expand Down Expand Up @@ -728,6 +732,7 @@ The implementation in `myobject.cc` is similar to the previous example:

namespace demo {

using v8::Context;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
Expand Down Expand Up @@ -773,7 +778,10 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
const int argc = 1;
Local<Value> argv[argc] = { args[0] };
Local<Function> cons = Local<Function>::New(isolate, constructor);
args.GetReturnValue().Set(cons->NewInstance(argc, argv));
Local<Context> context = isolate->GetCurrentContext();
Local<Object> instance =
cons->NewInstance(context, argc, argv).ToLocalChecked();
args.GetReturnValue().Set(instance);
}
}

Expand All @@ -783,7 +791,9 @@ void MyObject::NewInstance(const FunctionCallbackInfo<Value>& args) {
const unsigned argc = 1;
Local<Value> argv[argc] = { args[0] };
Local<Function> cons = Local<Function>::New(isolate, constructor);
Local<Object> instance = cons->NewInstance(argc, argv);
Local<Context> context = isolate->GetCurrentContext();
Local<Object> instance =
cons->NewInstance(context, argc, argv).ToLocalChecked();

args.GetReturnValue().Set(instance);
}
Expand Down Expand Up @@ -928,6 +938,7 @@ The implementation of `myobject.cc` is similar to before:

namespace demo {

using v8::Context;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
Expand Down Expand Up @@ -968,8 +979,11 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
// Invoked as plain function `MyObject(...)`, turn into construct call.
const int argc = 1;
Local<Value> argv[argc] = { args[0] };
Local<Context> context = isolate->GetCurrentContext();
Local<Function> cons = Local<Function>::New(isolate, constructor);
args.GetReturnValue().Set(cons->NewInstance(argc, argv));
Local<Object> instance =
cons->NewInstance(context, argc, argv).ToLocalChecked();
args.GetReturnValue().Set(instance);
}
}

Expand All @@ -979,7 +993,9 @@ void MyObject::NewInstance(const FunctionCallbackInfo<Value>& args) {
const unsigned argc = 1;
Local<Value> argv[argc] = { args[0] };
Local<Function> cons = Local<Function>::New(isolate, constructor);
Local<Object> instance = cons->NewInstance(argc, argv);
Local<Context> context = isolate->GetCurrentContext();
Local<Object> instance =
cons->NewInstance(context, argc, argv).ToLocalChecked();

args.GetReturnValue().Set(instance);
}
Expand Down